Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static variable for sound processing problem #2

Open
midilab opened this issue Feb 20, 2025 · 3 comments
Open

Static variable for sound processing problem #2

midilab opened this issue Feb 20, 2025 · 3 comments

Comments

@midilab
Copy link

midilab commented Feb 20, 2025

Hi @RobinSchmidt

I recently receive this bug report on JC303 repository: midilab/jc303#23

Looks like static variables that deals with sound processing directly in realtime are causing problems with more than one plugin loaded into DAW.

After reading a little about, looks like its up to the DAW to decide how he instantiate the plugin on computer memory, so most of them does it by using same memory allocation data for one or more of the same plugins loaded, wich leads to some strange behaviours for static data being shared between more than one instance of plugin.

What are you thoughts about this?

Once again thanks for this great source code!

@RobinSchmidt
Copy link
Owner

Hello! Thank you! I replied over there in the original bug report! ...to be honest, looking at the code today (more than 15 years later), I find a couple of things about it a bit embarrassing. I guess, it needs an overhaul anyway.

@midilab
Copy link
Author

midilab commented Feb 20, 2025

A source code that lives quite well for 15 years is already a miracle!

Kinda off-topic, but since the beginin i was plan to just make a sub module linking of your repository instead of copying the whole source code into JC303 repository(wich will makes it easy to evolve the development over time). I haven´t made it at the time because i needed to made some small changes to adapt the code to newer compilers specially on windows and linux.

So maybe i can pull request those changes in here? than later delete the whole source code on JC303 to create only a sb module reference.

@RobinSchmidt
Copy link
Owner

Oh - err - well - I'm not so sure, if I can properly maintain the code in a responsible way that you can rely on and I'm not yet familiar with the process of handling third party contributions via pull requests, so I'd recommend to keep a copy of the code in your own repo for the time being. You may send me the pull request anyway, though. But I'm not yet sure when I will be able to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants