You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The defaults paths are quite inconvenient if I run the cli from the installed package rather than the source directory, the config file as well as the downloaded database ends up in /home/<user>/miniconda3/envs/Pynteny/lib/python3.10/site-packages/
Right, that's inconvenient. What about adding the option to choose the directory where to download the database / write the config file? I think this may fix the issue.
pynteny/subcommands.py
wget is quite old and does not seem to be active. How about replacing it with a more maintained alternative? e.g. httpx, requests
Will try with requests.
As I said in the general comments, I would prefer if the default dirs were not relative to the package files. When installing pynteny inside a virtual env, this means that the database could be downloaded inside the venv, in a totally different place from the current working dir. I suggest using ~/.pynteny
pynteny/utils.py
As I said in the comments above, using the file location is quite inconvenient because when installed by conda it ends up in the venv directory
Addressing reviewer comments:
Right, that's inconvenient. What about adding the option to choose the directory where to download the database / write the config file? I think this may fix the issue.
Will try with requests.
The text was updated successfully, but these errors were encountered: