Skip to content

PyOpenSci REVIEW: pynteny.download and config default paths #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Robaina opened this issue Jan 25, 2023 · 0 comments · Fixed by #51
Closed

PyOpenSci REVIEW: pynteny.download and config default paths #49

Robaina opened this issue Jan 25, 2023 · 0 comments · Fixed by #51
Assignees
Labels
code review enhancement New feature or request

Comments

@Robaina
Copy link
Owner

Robaina commented Jan 25, 2023

Addressing reviewer comments:

CLI

  • The defaults paths are quite inconvenient if I run the cli from the installed package rather than the source directory, the config file as well as the downloaded database ends up in /home/<user>/miniconda3/envs/Pynteny/lib/python3.10/site-packages/

Right, that's inconvenient. What about adding the option to choose the directory where to download the database / write the config file? I think this may fix the issue.

pynteny/subcommands.py

  • wget is quite old and does not seem to be active. How about replacing it with a more maintained alternative? e.g. httpx, requests

Will try with requests.

  • As I said in the general comments, I would prefer if the default dirs were not relative to the package files. When installing pynteny inside a virtual env, this means that the database could be downloaded inside the venv, in a totally different place from the current working dir. I suggest using ~/.pynteny

pynteny/utils.py

@Robaina Robaina self-assigned this Jan 25, 2023
@Robaina Robaina added enhancement New feature or request code review labels Jan 25, 2023
@Robaina Robaina added this to TODO Jan 25, 2023
@Robaina Robaina moved this to In Progress in TODO Jan 25, 2023
@Robaina Robaina linked a pull request Jan 26, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in TODO Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant