From f49688a778cff90cfd43e1615fb93265931952a4 Mon Sep 17 00:00:00 2001
From: Haim Ashkenazi <haim@babysnakes.org>
Date: Sun, 28 Jan 2024 22:39:02 +0200
Subject: [PATCH] Fixed an error in IstioMatches handling.

  For both stable and next versions.
---
 docs/advanced/technical-overview.md              | 16 +++++++++-------
 .../version-0.1.0/advanced/technical-overview.md | 16 +++++++++-------
 2 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/docs/advanced/technical-overview.md b/docs/advanced/technical-overview.md
index 2cd0395..3d10465 100644
--- a/docs/advanced/technical-overview.md
+++ b/docs/advanced/technical-overview.md
@@ -23,11 +23,9 @@ this section to prevent confusion:
 ### IstioMatches
 
 IstioMatches corresponds to a subset of [Istio's HTTPMatchRequest][match] (specifically _headers_
-and _source labels_). Currently, _DynamicEnvironment_ IstioMatches are translated to
-HTTPMatchRequest as follows:
-
-* All headers are grouped into a single HTTPMatchRequest.
-* All source labels are grouped into a single HTTPMatchRequest.
+and _source labels_). _DynamicEnvironment_'s IstioMatches are translated to HTTPMatchRequest as
+follows, each item in the list of istio matches (regardless if it consists of headers, source
+labels, or both) corresponds to a single HttpMatchRequest.
 
 So, if you have the following IstioMatches object:
 
@@ -37,8 +35,10 @@ spec:
   istioMatches:
     - headers:
         end-user:
-    - sourceLabels:
+      sourceLabels:
         end-user: json
+    - sourceLabels:
+        end-user: joe
   [ ... ]
 ```
 
@@ -52,12 +52,14 @@ spec:
         - headers:
             end-user:
               prefix: jason
+          sourceLabels:
+            end-user: json
       route:
         - destination:
             [ ... ]
     - match:
         - sourceLabels:
-            end-user: json
+            end-user: joe
       route:
         - destination:
             [ ... ]
diff --git a/versioned_docs/version-0.1.0/advanced/technical-overview.md b/versioned_docs/version-0.1.0/advanced/technical-overview.md
index aaf8cae..7c86c7e 100644
--- a/versioned_docs/version-0.1.0/advanced/technical-overview.md
+++ b/versioned_docs/version-0.1.0/advanced/technical-overview.md
@@ -23,11 +23,9 @@ this section to prevent confusion:
 ### IstioMatches
 
 IstioMatches corresponds to a subset of [Istio's HTTPMatchRequest][match] (specifically _headers_
-and _source labels_). Currently, _DynamicEnvironment_ IstioMatches are translated to
-HTTPMatchRequest as follows:
-
-* All headers are grouped into a single HTTPMatchRequest.
-* All source labels are grouped into a single HTTPMatchRequest.
+and _source labels_). _DynamicEnvironment_'s IstioMatches are translated to HTTPMatchRequest as
+follows, each item in the list of istio matches (regardless if it consists of headers, source
+labels, or both) corresponds to a single HttpMatchRequest.
 
 So, if you have the following IstioMatches object:
 
@@ -37,8 +35,10 @@ spec:
   istioMatches:
     - headers:
         end-user:
-    - sourceLabels:
+      sourceLabels:
         end-user: json
+    - sourceLabels:
+        end-user: joe
   [ ... ]
 ```
 
@@ -52,12 +52,14 @@ spec:
         - headers:
             end-user:
               prefix: jason
+          sourceLabels:
+            end-user: json
       route:
         - destination:
             [ ... ]
     - match:
         - sourceLabels:
-            end-user: json
+            end-user: joe
       route:
         - destination:
             [ ... ]