Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logic/transaction: variable 'requester' never is declared on verify() function #55

Open
jarenal opened this issue Oct 30, 2017 · 0 comments
Open

logic/transaction: variable 'requester' never is declared on verify() function #55

jarenal opened this issue Oct 30, 2017 · 0 comments
Assignees
@vekexasia @jarenal @nerdvibe

Comments

@jarenal
Copy link
Member

jarenal commented Oct 30, 2017

Testing logic/transaction module I've noticed that verify() function is using a variable named 'requester' but never is declared.

https://github.com/RiseVision/rise-node/blob/development/logic/transaction.js#L439

Researching about this issue I've discovered that on Lisk version this variable is received as parameter.

https://github.com/LiskHQ/lisk/blob/development/logic/transaction.js#L365

Should we to do the same?
@jarenal jarenal mentioned this issue Nov 9, 2017
Closed
vekexasia added a commit that referenced this issue Mar 27, 2019
@vekexasia
Merge pull request #55 from RiseVision/feature/core-module-to-types

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d877f6d 
Move BaseCoreModule to types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vekexasia vekexasia

@jarenal jarenal

@nerdvibe nerdvibe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vekexasia @jarenal @nerdvibe