From d46a8eecfdce623ec9e035a6b189677af86057f8 Mon Sep 17 00:00:00 2001 From: remko_duursma Date: Thu, 6 May 2021 14:00:38 +0200 Subject: [PATCH 1/2] id not required for tabBox --- R/cards.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/cards.R b/R/cards.R index ee2ce0e3..5465106d 100644 --- a/R/cards.R +++ b/R/cards.R @@ -1105,7 +1105,7 @@ bs4InfoBox <- function(title, value = NULL, subtitle = NULL, icon = shiny::icon( #' @author David Granjon, \email{dgranjon@@ymail.com} #' #' @export -bs4TabCard <- function(..., id, selected = NULL, title = NULL, width = 6, +bs4TabCard <- function(..., id = NULL, selected = NULL, title = NULL, width = 6, height = NULL, side = c("left", "right"), type = NULL, footer = NULL, status = NULL, solidHeader = FALSE, background = NULL, collapsible = TRUE, collapsed = FALSE, closable = FALSE, maximizable = FALSE, From 3be4100b253f74d44a36ac7a3fd9ea086a507d4b Mon Sep 17 00:00:00 2001 From: remko_duursma Date: Thu, 6 May 2021 16:21:29 +0200 Subject: [PATCH 2/2] nav-icon class was not assigned --- R/dashboardSidebar.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/dashboardSidebar.R b/R/dashboardSidebar.R index c187ded9..91198b35 100644 --- a/R/dashboardSidebar.R +++ b/R/dashboardSidebar.R @@ -365,7 +365,7 @@ bs4SidebarMenuItem <- function(text, ..., icon = NULL, badgeLabel = NULL, badgeC if (!is.null(icon)) { tagAssert(icon, type = "i") - icon$attribs$cl <- paste0(icon$attribs$cl, " nav-icon") + icon$attribs$class <- paste0(icon$attribs$class, " nav-icon") } if (!is.null(href) + !is.null(tabName) + (length(subItems) > 0) != 1) {