feat: limit connection by measurement #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanKung
changed the title
RyanKung
changed the title
Ma233
approved these changes
Aug 1, 2023
derive/src/derives.rs
Outdated
| #[cfg(not(feature = "core_crate"))] | ||
| quote! { | ||
| use rings_core::measure::measure::MessageRecvBehaviour; | ||
| use rings_core::measure::measure::MessageSendehaviour; |
There was a problem hiding this comment.
Suggested change
| use rings_core::measure::measure::MessageSendehaviour; | |
| use rings_core::measure::measure::MessageSendBehaviour; |
| disconn, | ||
| conn - disconn | ||
| ); | ||
| ((conn - disconn) as i16) < THRESHOLD |
There was a problem hiding this comment.
To ensure adaptability across different orders of magnitude, it may be more effective to calculate using the admission base and ratio rather than simply taking the difference.
There was a problem hiding this comment.
Agree, this algorithm is just a very basically impl for current situation, we needs ratio based, time weighted based and so on. And futher more, we allow users to compose those impls together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
🟤 What is the current behavior? (You can also link to an open issue here)
related issue #399
In the current scenario, the DHT may attempt to establish a connection to did_a, but this can fail due to incorrect configuration or network issues. The existing implementation might repeatedly try to establish the connection, potentially causing the system's file descriptor limit to be reached very quickly.
🟢 What is the new behavior (if this is a feature change)?
good.connect,connect_viaanddisconnect.☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
ℹ️ Other information
After this modify, if a node is behaviour no good, it will printout errors.
Closes #issue