Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known bugs #3

Open
2 of 4 tasks
RyanKung opened this issue Jul 23, 2022 · 6 comments
Open
2 of 4 tasks

Known bugs #3

RyanKung opened this issue Jul 23, 2022 · 6 comments
Assignees

Comments

@RyanKung
Copy link
Member

RyanKung commented Jul 23, 2022

  • 1.
  • 2.
  • 3.
  • 4.
  1. Address from ws should deduplicate here
    image
@RyanKung
Copy link
Member Author

RyanKung commented Jul 23, 2022

  1. memory leaks here.
    image
  • FrontEnd should not hold ref of Arc, or we should use std::sync::Weak

related code.:

https://github.com/RingsNetwork/rings-fe/blob/master/contexts/RingsProvider.tsx#L15
https://github.com/RingsNetwork/rings-node/blob/master/src/browser/mod.rs#L349

@googolmo
Copy link
Contributor

@RyanKung RingsNetwork/rings#240 try to fix the memory leaks issue

@RyanKung
Copy link
Member Author

RyanKung commented Jul 24, 2022

  1. Fe should not panic here, if all nodes are offline, maybe a reconnect button?

image

@RyanKung
Copy link
Member Author

RyanKung commented Jul 24, 2022

  1. After reconnect nodes, some connected node is not existed in swarm table.

IMAGE 2022-07-24 22:44:39

IMAGE 2022-07-24 22:44:12

@gaowhen
Copy link
Contributor

gaowhen commented Jul 25, 2022

1 is fixed here.

@RyanKung
Copy link
Member Author

@RyanKung RingsNetwork/rings-node#240 try to fix the memory leaks issue

Still not work, I modified Fe to print out all pending / peers

image

And on console, we can see there is only few of them.

image

But actually, on chrome://webrtc-internals and about:webrtc page, there is more than halv dozen connections.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants