Improve logic when comparing items with outdated IMDB ID + improve driver handling #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
RileyXX
commented
Jan 18, 2025
RileyXX
commented
- Ignore processing items with matching Title, Year and Type, AND have non-matching IMDB IDs. This is to prevent outdated IMDB IDs from Trakt interfering with the comparison logic. This prevents the script from failing to process the same items on each run.
- Improve driver handling, passing both the driver and wait variables and returning them from the get_page_with_retries function to avoid driver instance mismatches and other related errors.
RileyXX
deleted the
improve-logic-when-comparing-items-with-outdated-imdb-id-improve-driver-handling
branch
This was
linked to
issues
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.