Persistent bans

[CuriousMike56]

Currently, server bans are cleared when the server restarts. It would be nice if they were stored in a file, by username & IP.

[CuriousMike56]

To expand on this, there should also be banned vehicles and usernames. The server scripts can ban vehicles, but the server must be restarted for the changes to apply.

[ohlidalp]

Hi.

RoRserver has persistent state AUTH_BANNED(32) based on token in authfile - this is checked first when connecting.

There are also IP-bans which are created by "!ban " command and aren't persisted. Nickname is recorded but not checked:

ror-server/source/server/sequencer.cpp

Lines 219 to 225 in 17cc7b5

	// check if banned
	SWBaseSocket::SWBaseError error;
	if (Sequencer::IsBanned(sock->get_peerAddr(&error).c_str())) {
	Logger::Log(LOG_VERBOSE, "rejected banned IP %s", sock->get_peerAddr(&error).c_str());
	Messaging::SendMessage(sock, RoRnet::MSG2_BANNED, 0, 0, 0, 0);
	return;
	}

Draft

• Maintain "blacklist.json" containing existing ban-records:

  ror-server/source/server/sequencer.h

  Lines 137 to 143 in 17cc7b5

  	struct ban_t {
  	unsigned int uid; //!< userid
  	char ip[40]; //!< ip of banned client
  	char nickname[RORNET_MAX_USERNAME_LEN]; //!< Username, this is what they are called to
  	char bannedby_nick[RORNET_MAX_USERNAME_LEN]; //!< Username, this is what they are called to
  	char banmsg[256]; //!< why he got banned
  	};

• Add nick-blacklist by adding a "type {IP, NICK, BOTH}" field to the above struct.
• Vehicle bans: add "![un]blacklist " commands, create new struct similar to ban_t and persist it in "blacklist.json" as well.
• Vehicle bans: record { truckfile name/truck full name, GUID }, but those be easily faked, we may need to record node/beam/wheel/command/hydro counts, possibly with custom checksums - whatever data server has available.