Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Boost Context #141

Open
mdsitton opened this issue Oct 22, 2023 · 3 comments
Open

Update Boost Context #141

mdsitton opened this issue Oct 22, 2023 · 3 comments

Comments

@mdsitton
Copy link
Contributor

mdsitton commented Oct 22, 2023

I've been looking over the version in this repo vs the upstream and there is a few issues i'm finding compared to the latest version, plus we'd probably get apple silicon support which would be nice: boostorg/context@1c763c9

Here are some of the commits that should certainly be applied regardless looking over everything:
boostorg/context@50ebf5b

boostorg/context@002ed38

@RichieSams
Copy link
Owner

RichieSams commented Oct 23, 2023

I'd prefer to keep it as a fork. (one of the reasons I forked it was that the boost context API kept changing). That said, we can definitely port their fixes. Apple silicon shouldn't be too hard to add, since we already have ARM for elf. MachO uses aapcs calling convention as well. So the only difference between elf and macho asm files is some calling macros

@mdsitton
Copy link
Contributor Author

mdsitton commented Oct 23, 2023

i mean to be fair the fcontext api hasn't changed at all since you forked it 6 years ago as far as i can tell: https://github.com/boostorg/context/commits/develop/include/boost/context/detail/fcontext.hpp
And development over time on the project has been trending downwards since then:
image

Another option is using maybe this fork which while isn't fully up-to-date with the current boost context, it's a lot newer and has all of the backends functional atleast.
https://github.com/septag/deboost.context

@RichieSams
Copy link
Owner

That's an interesting option. It's got some decent stars and is used by some facebook research project. I don't like the API change, but I'm also curmudgeonly. I'll live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants