Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility conflict/override? #3

Open
Foodlenz opened this issue May 31, 2023 · 2 comments
Open

Compatibility conflict/override? #3

Foodlenz opened this issue May 31, 2023 · 2 comments

Comments

@Foodlenz
Copy link

Foodlenz commented May 31, 2023

The compatibility packaged with this Details seems to be out of date/missing some of your previous fixes. When paired with other addons that use compatibility it can break some of the things that were already fixed in their versions of compatibility.

ie. Spell names that have parenthesis.
Your fixed version as part of WeakAuras:
RichSteini/WeakAuras2-TBC-2.4.3@329589b
image

vs

The one packed as part of Details:
image

Which leads to the previous fix not working when both addons are enabled.

EDIT: Hmm not sure what the issue is actually. The above is true, the compatibility included is an older version. But having manually changed the files to match, the problem still occurs when both Details and Weakauras are enabled at the same time.

Double EDIT: Simply deleting that !compatibility inside the Details folder seems to have fixed all issues. Unsure if it'll cause others though.
image

@RichSteini
Copy link
Owner

!compatibility (not the addon) is mainly about the enhanced UnitAura function. I have no problem removing it, but i am not sure whether removing it has other side effects. Just tell me if you notice anything while testing and i can make the change if you give me an ok.

@RichSteini
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants