Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make data checks in marks optional #261

Open
jwildfire opened this issue Sep 30, 2019 · 2 comments · May be fixed by #270
Open

Make data checks in marks optional #261

jwildfire opened this issue Sep 30, 2019 · 2 comments · May be fixed by #270
Assignees
@samussiah
Milestone
v1.11.7

Comments

@jwildfire
Copy link
Contributor

Allow user to disable the data checks in marks. This can be useful when columns are created as part of custom callbacks, but aren't available in the original data when init() is called.
@jwildfire
Copy link
Contributor Author

Think we just need to add an option (e.g. this.config.marks.checkColumns with default = true) and then tweak this line to:

if (this.config.marks & this.config.marks.testColumns)

@jwildfire jwildfire added this to the v1.11.7 milestone Nov 18, 2019
@jwildfire
Copy link
Contributor Author

Just ran in to this again - it is annoying.

samussiah added a commit that referenced this issue Dec 13, 2019
@samussiah
fix #261
f7037ad
@samussiah samussiah self-assigned this Dec 13, 2019
@samussiah samussiah linked a pull request Dec 18, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samussiah samussiah

Labels
None yet
Projects
None yet
Milestone
v1.11.7
Development

Successfully merging a pull request may close this issue.

optionalize data requirements for mark[].values RhoInc/Webcharts
2 participants
@jwildfire @samussiah