Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Falsey filter values are removed from the dropdown. #249

Open
samussiah opened this issue Apr 30, 2019 · 0 comments · May be fixed by #271
Open

Falsey filter values are removed from the dropdown. #249

samussiah opened this issue Apr 30, 2019 · 0 comments · May be fixed by #271
Assignees
@samussiah
Labels
bug controls
Milestone
v1.11.7

Comments

@samussiah
Copy link
Contributor

e.g. '', 0, false here

It'd be more transparent to throw falsey values in the subsetter, perhaps coercing to character.
@jwildfire jwildfire added the bug label Nov 18, 2019
@jwildfire jwildfire added this to the v1.11.7 milestone Nov 18, 2019
@samussiah samussiah self-assigned this Dec 13, 2019
samussiah added a commit that referenced this issue Dec 13, 2019
@samussiah
fix #249
8ebb0ad
@samussiah samussiah linked a pull request Dec 18, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samussiah samussiah

Labels
bug controls
Projects
None yet
Milestone
v1.11.7
Development

Successfully merging a pull request may close this issue.

make falsy filter options and legend values apparent RhoInc/Webcharts
2 participants
@jwildfire @samussiah