Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-evo miche tree has species that don't exist in the results #5549

Open
hhyyrylainen opened this issue Sep 30, 2024 · 1 comment
Open

Comments

@hhyyrylainen
Copy link
Member

When working on the food chain tab I noticed that there's an inconsistency in what species it found to be in a patch based on the miche tree and what the auto-evo report showed. Now when adding some workarounds I noticed that the miche tree contains species that aren't in the auto-evo results at all. To me this indicates that there's probably some bug with putting species into the miche tree that shouldn't be in there (all species that are processed by auto-evo should have a result entry for it, so I suspect that maybe some temporarily generated species are accidentally inserted into the miche tree).

@hhyyrylainen
Copy link
Member Author

Potentially related code:

var newPopulation =
MichePopulation.CalculateMicrobePopulationInPatch(mutation.MutatedSpecies, miche!, patch,
cache);
if (newPopulation > Constants.AUTO_EVO_MINIMUM_VIABLE_POPULATION)
{
results.AddPossibleMutation(mutation.MutatedSpecies,
new KeyValuePair<Patch, long>(patch, newPopulation), mutation.AddType,
mutation.ParentSpecies);
}

hhyyrylainen added a commit that referenced this issue Oct 1, 2024
* Refactored one place still using compound string names

* Started working on the food chain tab

* Initial GUI files for the food chain tab

* Fix DraggableScrollContainer default child for Godot 4

* Re-architectured how food chain tab drag node is set

* Put some placeholder display in the food chain tab

* Test display now works

* Refactored final auto-evo pop calculation to a helper method

* Food chain now shows all species and basic lines between them

* Created a food chain resource icon

* Refactored how the current patch is handled in the report tab

hopefully this approach will be cleaner to get fully working in all corner cases

* Food chain tab now also displays relationships to resources

* Fix a missing BOM

* Prune non-existent species entries from food chain tab

#5549

* Added a graph layout algorithm for food chain

* Tried to improve the graph display a bit

and added click handler

* Switched to a different graph library

* Sorted out the license file situation

* Make sure player is not marked extinct

due to missing from miches

* Switch to a different more reliable algorithm

and add padding and margin to be able to center the nodes for nice visual result

* Tweaked the algorithm settings a tiny bit

* Fixed bug with treating all compound nodes the same

in the food chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: High priority bugs / issues
Development

No branches or pull requests

1 participant