Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change handling of declined pledges if required to make sense #581

Open
hhyyrylainen opened this issue Feb 13, 2023 · 0 comments
Open

Change handling of declined pledges if required to make sense #581

hhyyrylainen opened this issue Feb 13, 2023 · 0 comments
Labels
C# enhancement New feature or request

Comments

@hhyyrylainen
Copy link
Member

The API documentation says:

declined_since indicates the date of the most recent payment if it failed, or `null` if the most recent payment succeeded. A pledge with a non-null declined_since should be treated as invalid. 

but I noticed a user with a really recent creation date but then a few hours later they were declined. So perhaps we should change the declined since check to check that the declined since time is in the future (or in the last 4 hours)?

@hhyyrylainen hhyyrylainen added enhancement New feature or request C# labels Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# enhancement New feature or request
Projects
Status: Backburner
Development

No branches or pull requests

1 participant