Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid the use of return switch #4733

Merged
merged 4 commits into from
Jan 29, 2025
Merged

fix: Avoid the use of return switch #4733

merged 4 commits into from
Jan 29, 2025

Conversation

facumenzella
Copy link
Contributor

@facumenzella facumenzella commented Jan 29, 2025

Motivation

This PR tries to avoid using return switch because it breaks the CI

purchases-ios/RevenueCatUI/Templates/V2/ViewHelpers/BadgeModifier.swift:140:9: error: Forbidden 'return switch' usage Violation: Inline 'return switch' is not allowed. (return_switch_forbidden)

This is not bullet-proof, because it will only catch return switch and the regex is not perfect. But it's better than nothing 😓

Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got the broken one so let's go!

@facumenzella facumenzella marked this pull request as ready for review January 29, 2025 10:49
@facumenzella facumenzella enabled auto-merge (squash) January 29, 2025 10:50
@facumenzella
Copy link
Contributor Author

@joshdholtz this should fix the release 🚀

@facumenzella facumenzella merged commit 5df4d6b into main Jan 29, 2025
10 checks passed
@facumenzella facumenzella deleted the feat/return-switch branch January 29, 2025 11:01
@vegaro vegaro restored the feat/return-switch branch January 29, 2025 11:44
@vegaro vegaro deleted the feat/return-switch branch January 29, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants