-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uiPreviewMode
to DangerousSettings
#4714
Conversation
I have added the
Of course, I'm open to suggestions about adding the |
I triggered a re-run of the iOS 18 tests since the failures seemed unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
/** | ||
* if `true`, the SDK will return a set of mock products instead of the | ||
* products obtained from StoreKit. This is useful for testing or preview purposes. | ||
*/ | ||
@_spi(Internal) public let uiPreviewMode: Bool | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can add the API tests to go along with it in this same PR? Those serve to also showcase the usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in f406e82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@_spi
all the things! 🙌
I don't have a strong opinion on whether it should be in DangerousSettings
or not. I'd also be okay to just move this to the regular Configuration
. However, since it's internal we can always change this later.
@RCGitBot please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice knowing this 💪
Checklist
purchases-android
and hybridsMotivation
We need a way to activate the UI Preview mode in the SDK to enable the Paywall Previews functionality in the RC app without actually adding any new public APIs to the SDK
Description
This PR adds a new property to
DangerousSettings
:uiPreviewMode
.@_spi
attribute.