Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mag_normalization error #21

Open
RevathiJambunathan opened this issue Jul 21, 2020 · 2 comments · Fixed by #27 or #32
Open

Add mag_normalization error #21

RevathiJambunathan opened this issue Jul 21, 2020 · 2 comments · Fixed by #27 or #32

Comments

@RevathiJambunathan
Copy link
Owner

Currently, in MacroscopicEvolveM.cpp, mag_normalization_error=0.1 is hard-coded. This needs to be added as a user-defined inputs with appropriate docs.
@ruohai0925 ruohai0925 mentioned this issue Aug 1, 2020
Merged
@RevathiJambunathan RevathiJambunathan linked a pull request Aug 4, 2020 that will close this issue
Add some user-defined parameters #27
Merged
@ajnonaka
Copy link

We need to implement this in MacroscopicEvolveM_2nd.cpp.
We need to test whether we apply this normalization once at the enter of the iterations, or after each iteration (before you compute the error).

@RevathiJambunathan RevathiJambunathan linked a pull request Aug 28, 2020 that will close this issue
Added normalization of M magnitude at each iteration of 2nd order algorithm #32
Merged
@ajnonaka
Copy link

ajnonaka commented Sep 2, 2020

I believe we can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ajnonaka @RevathiJambunathan