-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some PRs from upstream #13
Comments
Aloshi#430 looks good. I'll do a PR Aloshi#455 has too many whitespace changes for my liking along with code changes and will mess up future merges no doubt. The Shutdown is sorted, and the md hashing is for the gamesdb branch so we can leave those. Any others of interest in other forks ? https://github.com/batkinson/EmulationStation has a few possible improvements |
(and recalbox - the favourites in recalbox is nice - I think it's a combination of some upstream PR, but they might have added their own changes too) |
Adding these for comment - not checked the code etc, just ideas of things we could look into merging. Aloshi#536 - Add a sort option for the scrapped name Aloshi#517 - Hide mouse cursor early Favourite changes (I guess we need one or the other) |
recalbox@61eafba - recalbox favourites implementation based on above two patches. not compared it |
(recalbox made a bunch of changes to favourites after that patch too). We are probably best to just look at the upstream ones, as they will be less customised. |
(shameless plug) |
Is the shutdown issue on Linux really sorted? I have to ctrl+alt+supr a couple of times for it to work, but maybe is just on my rpi3. |
It should be noted that as of March 19th, the project is officially unmaintained: Aloshi#563 (comment) |
Update README.md with SDL2 brew for OSX
How many years are you guys going to cling on that someone somewhere will pick this up upstream? It's now been over 2 years since anything was committed upstream. Are you planning to drop emulation station or something? I believe Recalbox is starting to leave you in the dust in large part because you refuse to pull in any upstream pull requests. Due to current MIT licensing you could even shamelessly steal half of Recalbox's code probably with minimal effort. I like the way you guys do your build and some things better, but until you add favorites at least I will probably have to stick with Recalbox. |
Trolling ? Feel free to continue using recalbox. |
Seriously? That's your response? This is a legitimate concern that you apparently felt the need to leave this issue open for over a year with little traction. Is there an official stance or policy on emulation station in regards to Retropie since emulation station is dead? |
Yes - based on your post. What are you talking about ? Just because we haven't implemented favourites you feel the need to have a moan. Have you even checked the commit log ? Our fork is in active development. We have different goals from Recalbox. If you don't like our aims - fine - but moaning on this thread isn't going to help. |
Are any updates expected from this or can this be closed? |
Yeah. Can be. Thanks |
Update emulationstation2.po
Merge from Batocera master
Upstream was not updated for a while. There are some open PRs we could evaluate and use:
-Symlink support Aloshi#430
-Code fixes Aloshi#455
-Proper shutdown Aloshi#502
-Improve md hashing Aloshi#422
The text was updated successfully, but these errors were encountered: