From 1af4246d7b5fe29788fb8f95eea563c86a32b8d9 Mon Sep 17 00:00:00 2001 From: ThE-MaRaC Date: Fri, 12 May 2017 10:42:21 +0000 Subject: [PATCH 1/4] Correction for https://github.com/RestComm/jain-slee/issues/111 --- src/gov/nist/core/Debug.java | 4 ++-- src/gov/nist/core/LexerCore.java | 3 ++- src/gov/nist/javax/sip/SipProviderImpl.java | 22 +++++++++++++++++-- src/gov/nist/javax/sip/parser/Parser.java | 2 +- .../javax/sip/stack/TCPMessageChannel.java | 2 ++ .../javax/sip/stack/TLSMessageChannel.java | 1 + .../javax/sip/stack/UDPMessageChannel.java | 2 ++ 7 files changed, 30 insertions(+), 6 deletions(-) diff --git a/src/gov/nist/core/Debug.java b/src/gov/nist/core/Debug.java index e414017f8..2b94839b5 100755 --- a/src/gov/nist/core/Debug.java +++ b/src/gov/nist/core/Debug.java @@ -34,8 +34,8 @@ */ public class Debug { - public static boolean debug = false; - public static boolean parserDebug = false; + public static boolean debug = true; + public static boolean parserDebug = true; static StackLogger stackLogger; diff --git a/src/gov/nist/core/LexerCore.java b/src/gov/nist/core/LexerCore.java index 957a85e29..e54682766 100755 --- a/src/gov/nist/core/LexerCore.java +++ b/src/gov/nist/core/LexerCore.java @@ -736,7 +736,8 @@ public String number() throws ParseException { int startIdx = ptr; try { - if (!isDigit(lookAhead(0))) { + char c = lookAhead(0); + if (c != '-' && !isDigit(c)) { throw new ParseException( buffer + ": Unexpected token at " + lookAhead(0), ptr); diff --git a/src/gov/nist/javax/sip/SipProviderImpl.java b/src/gov/nist/javax/sip/SipProviderImpl.java index 061d09ce2..e70096c6a 100755 --- a/src/gov/nist/javax/sip/SipProviderImpl.java +++ b/src/gov/nist/javax/sip/SipProviderImpl.java @@ -80,6 +80,7 @@ import javax.sip.TransactionUnavailableException; import javax.sip.address.Hop; import javax.sip.header.CallIdHeader; +import javax.sip.header.ToHeader; import javax.sip.message.Request; import javax.sip.message.Response; @@ -491,8 +492,25 @@ public ServerTransaction getNewServerTransaction(Request request) SIPRequest sipRequest = (SIPRequest) request; try { sipRequest.checkHeaders(); - } catch (ParseException ex) { - throw new TransactionUnavailableException(ex.getMessage(), ex); + } catch (ParseException pe) { + try { + SIPResponse badReqRes = sipRequest.createResponse(Response.BAD_REQUEST, + "Bad Request (" + pe.getLocalizedMessage() + ')'); + // Should add a to-tag if not already present... + ToHeader to = (ToHeader) badReqRes.getHeader(ToHeader.NAME); + if (to.getTag() == null || to.getTag().isEmpty()) { + to.setTag("badreq"); + badReqRes.setHeader(to); + } + if (logger.isLoggingEnabled(LogWriter.TRACE_DEBUG)) { + logger.logDebug("Sending automatic 400 Bad Request:"); + logger.logDebug(badReqRes.toString()); + } + sendResponse(badReqRes); + } catch (Exception ex) { + logger.logError("error sending response", ex); + } + throw new TransactionUnavailableException(pe.getMessage(), pe); } if ( request.getMethod().equals(Request.ACK)) { diff --git a/src/gov/nist/javax/sip/parser/Parser.java b/src/gov/nist/javax/sip/parser/Parser.java index a614225a1..e4dd92924 100755 --- a/src/gov/nist/javax/sip/parser/Parser.java +++ b/src/gov/nist/javax/sip/parser/Parser.java @@ -43,7 +43,7 @@ public abstract class Parser extends ParserCore implements TokenTypes { protected ParseException createParseException(String exceptionString) { return new ParseException( - lexer.getBuffer() + ":" + exceptionString, + lexer.getBuffer().trim() + ":" + exceptionString, lexer.getPtr()); } diff --git a/src/gov/nist/javax/sip/stack/TCPMessageChannel.java b/src/gov/nist/javax/sip/stack/TCPMessageChannel.java index a97989943..a5e7d424c 100755 --- a/src/gov/nist/javax/sip/stack/TCPMessageChannel.java +++ b/src/gov/nist/javax/sip/stack/TCPMessageChannel.java @@ -35,6 +35,7 @@ import gov.nist.javax.sip.header.CallID; import gov.nist.javax.sip.header.ContentLength; import gov.nist.javax.sip.header.From; +import gov.nist.javax.sip.header.MaxForwards; import gov.nist.javax.sip.header.RequestLine; import gov.nist.javax.sip.header.StatusLine; import gov.nist.javax.sip.header.To; @@ -445,6 +446,7 @@ public void handleException(ParseException ex, SIPMessage sipMessage, || hdrClass.equals(Via.class) || hdrClass.equals(CallID.class) || hdrClass.equals(ContentLength.class) + || hdrClass.equals(MaxForwards.class) || hdrClass.equals(RequestLine.class) || hdrClass .equals(StatusLine.class))) { if (logger.isLoggingEnabled(LogWriter.TRACE_DEBUG)) { diff --git a/src/gov/nist/javax/sip/stack/TLSMessageChannel.java b/src/gov/nist/javax/sip/stack/TLSMessageChannel.java index 007d09401..2a8a41771 100755 --- a/src/gov/nist/javax/sip/stack/TLSMessageChannel.java +++ b/src/gov/nist/javax/sip/stack/TLSMessageChannel.java @@ -434,6 +434,7 @@ public void handleException(ParseException ex, SIPMessage sipMessage, || hdrClass.equals(Via.class) || hdrClass.equals(CallID.class) || hdrClass.equals(ContentLength.class) + || hdrClass.equals(MaxForwards.class) || hdrClass.equals(RequestLine.class) || hdrClass .equals(StatusLine.class))) { if (logger.isLoggingEnabled(LogWriter.TRACE_DEBUG)) diff --git a/src/gov/nist/javax/sip/stack/UDPMessageChannel.java b/src/gov/nist/javax/sip/stack/UDPMessageChannel.java index 2bc5b320d..a1e813f1e 100755 --- a/src/gov/nist/javax/sip/stack/UDPMessageChannel.java +++ b/src/gov/nist/javax/sip/stack/UDPMessageChannel.java @@ -42,6 +42,7 @@ import gov.nist.javax.sip.header.CallID; import gov.nist.javax.sip.header.ContentLength; import gov.nist.javax.sip.header.From; +import gov.nist.javax.sip.header.MaxForwards; import gov.nist.javax.sip.header.RequestLine; import gov.nist.javax.sip.header.StatusLine; import gov.nist.javax.sip.header.To; @@ -684,6 +685,7 @@ public void handleException(ParseException ex, SIPMessage sipMessage, || hdrClass.equals(Via.class) || hdrClass.equals(CallID.class) || hdrClass.equals(ContentLength.class) + || hdrClass.equals(MaxForwards.class) || hdrClass.equals(RequestLine.class) || hdrClass .equals(StatusLine.class))) { if (logger.isLoggingEnabled(LogWriter.TRACE_DEBUG)) { From 346264e5d5e800a3fc37034d3c9c1f2a7292f446 Mon Sep 17 00:00:00 2001 From: ThE-MaRaC Date: Thu, 18 May 2017 10:16:28 +0200 Subject: [PATCH 2/4] Set debug values to false --- src/gov/nist/core/Debug.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gov/nist/core/Debug.java b/src/gov/nist/core/Debug.java index 2b94839b5..e414017f8 100755 --- a/src/gov/nist/core/Debug.java +++ b/src/gov/nist/core/Debug.java @@ -34,8 +34,8 @@ */ public class Debug { - public static boolean debug = true; - public static boolean parserDebug = true; + public static boolean debug = false; + public static boolean parserDebug = false; static StackLogger stackLogger; From 0ca3cd2126712871ec3b69588758621d45c8f8b1 Mon Sep 17 00:00:00 2001 From: ThE-MaRaC Date: Thu, 18 May 2017 10:40:12 +0200 Subject: [PATCH 3/4] JUnit TC for negative Content-Length --- .../javax/sip/parser/ContentLengthParserTest.java | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/test/unit/gov/nist/javax/sip/parser/ContentLengthParserTest.java b/src/test/unit/gov/nist/javax/sip/parser/ContentLengthParserTest.java index 53f8fa18c..bd3fa76f9 100755 --- a/src/test/unit/gov/nist/javax/sip/parser/ContentLengthParserTest.java +++ b/src/test/unit/gov/nist/javax/sip/parser/ContentLengthParserTest.java @@ -42,4 +42,17 @@ public void testParser(){ } + // https://github.com/RestComm/jain-slee/issues/111 + public void testNegativeContentLength(){ + String error = ""; + try { + final String header = "Content-Length: -123 \n"; + System.out.print(header); + createParser(ContentLengthParser.class, header).parse(); + } catch (java.text.ParseException ex) { + System.out.println(ex.getMessage()); + error = ex.getLocalizedMessage(); + } + assertTrue(error.contains("the contentLength parameter is <0")); + } } From ccd0e6698499fe6a298a69cefaace49b1f92f376 Mon Sep 17 00:00:00 2001 From: ThE-MaRaC Date: Thu, 18 May 2017 14:04:02 +0200 Subject: [PATCH 4/4] JUnit TC for INVITE with missing Contact header --- .../sip/stack/RejectBadInviteMessageTest.java | 241 ++++++++++++++++++ 1 file changed, 241 insertions(+) create mode 100644 src/test/unit/gov/nist/javax/sip/stack/RejectBadInviteMessageTest.java diff --git a/src/test/unit/gov/nist/javax/sip/stack/RejectBadInviteMessageTest.java b/src/test/unit/gov/nist/javax/sip/stack/RejectBadInviteMessageTest.java new file mode 100644 index 000000000..acba2963d --- /dev/null +++ b/src/test/unit/gov/nist/javax/sip/stack/RejectBadInviteMessageTest.java @@ -0,0 +1,241 @@ +package test.unit.gov.nist.javax.sip.stack; + +import java.text.ParseException; +import java.util.Properties; + +import javax.sip.DialogTerminatedEvent; +import javax.sip.IOExceptionEvent; +import javax.sip.ListeningPoint; +import javax.sip.PeerUnavailableException; +import javax.sip.RequestEvent; +import javax.sip.ResponseEvent; +import javax.sip.ServerTransaction; +import javax.sip.SipFactory; +import javax.sip.SipListener; +import javax.sip.SipProvider; +import javax.sip.SipStack; +import javax.sip.TimeoutEvent; +import javax.sip.TransactionTerminatedEvent; +import javax.sip.TransactionUnavailableException; +import javax.sip.address.Address; +import javax.sip.address.AddressFactory; +import javax.sip.header.ContactHeader; +import javax.sip.header.HeaderFactory; +import javax.sip.header.ReasonHeader; +import javax.sip.header.ToHeader; +import javax.sip.message.MessageFactory; +import javax.sip.message.Request; +import javax.sip.message.Response; + +import gov.nist.javax.sip.stack.NioMessageProcessorFactory; +import junit.framework.TestCase; + +public class RejectBadInviteMessageTest extends TestCase { + + public class Shootist implements SipListener { + private SipStack sipStack; + + private SipProvider sipProvider; + + private AddressFactory addressFactory; + + private MessageFactory messageFactory; + + private HeaderFactory headerFactory; + + private ListeningPoint udpListeningPoint; + + private static final String myAddress = "127.0.0.1"; + + private static final int myPort = 5070; + + private boolean sawTransactionUnavailableException = false; + + private boolean sawBadRequestResponse = false; + + @Override + public void processRequest(RequestEvent requestEvent) { + Request request = requestEvent.getRequest(); + ServerTransaction serverTransactionId = requestEvent.getServerTransaction(); + + System.out.println("Request " + request.getMethod() + " received at " + sipStack.getStackName() + + " with server transaction id " + serverTransactionId); + + if (request.getMethod().equals(Request.INVITE)) { + processInvite(requestEvent); + } + } + + public void processInvite(RequestEvent requestEvent) { + SipProvider sipProvider = (SipProvider) requestEvent.getSource(); + Request request = requestEvent.getRequest(); + try { + + Response okResponse = messageFactory.createResponse(Response.OK, request); + Address address = addressFactory.createAddress("Shootme "); + ContactHeader contactHeader = headerFactory.createContactHeader(address); + ToHeader toHeader = (ToHeader) okResponse.getHeader(ToHeader.NAME); + toHeader.setTag("4321"); // Application is supposed to set. + okResponse.addHeader(contactHeader); + ServerTransaction stx = requestEvent.getServerTransaction(); + if (stx == null) { + stx = sipProvider.getNewServerTransaction(request); + stx.sendResponse(okResponse); + } + } catch (TransactionUnavailableException ex) { + this.sawTransactionUnavailableException = true; + System.out.println("Saw TransactionUnavailableException"); + } catch (Exception ex) { + System.err.println("Unexpected exception" + ex); + fail("Unexpected Exception seen"); + } + } + + @Override + public void processResponse(ResponseEvent responseEvent) { + Response response = responseEvent.getResponse(); + System.out.println("Response " + response.getStatusCode() + " received"); + + if (response.getStatusCode() == Response.BAD_REQUEST) { + this.sawBadRequestResponse = true; + System.out.println("ReasonPhrase is " + response.getReasonPhrase()); + ReasonHeader reason = (ReasonHeader) response.getHeader(ReasonHeader.NAME); + if (reason != null) { + System.out.println("ReasonHeader cause=" + reason.getCause() + ", text=" + reason.getText()); + } else { + System.out.println("ReasonHeader not available"); + } + } + } + + @Override + public void processDialogTerminated(DialogTerminatedEvent dialogTerminatedEvent) { + System.out.println("dialogTerminatedEvent"); + } + + @Override + public void processTimeout(TimeoutEvent timeoutEvent) { + System.out.println("Got a timeout " + timeoutEvent.getClientTransaction()); + } + + @Override + public void processTransactionTerminated(TransactionTerminatedEvent transactionTerminatedEvent) { + System.out.println("Transaction terminated event recieved"); + } + + @Override + public void processIOException(IOExceptionEvent exceptionEvent) { + System.out.println( + "IOException happened for " + exceptionEvent.getHost() + " port = " + exceptionEvent.getPort()); + } + + public void init() { + SipFactory sipFactory = null; + sipStack = null; + sipFactory = SipFactory.getInstance(); + sipFactory.setPathName("gov.nist"); + Properties properties = new Properties(); + // If you want to try TCP transport change the following to + String transport = "udp"; + String peerHostPort = myAddress + ':' + myPort; + properties.setProperty("javax.sip.OUTBOUND_PROXY", peerHostPort + "/" + transport); + // If you want to use UDP then uncomment this. + properties.setProperty("javax.sip.STACK_NAME", "shootist"); + + // The following properties are specific to nist-sip + // and are not necessarily part of any other jain-sip + // implementation. + // You can set a max message size for tcp transport to + // guard against denial of service attack. + properties.setProperty("gov.nist.javax.sip.DEBUG_LOG", "shootistdebug.txt"); + properties.setProperty("gov.nist.javax.sip.SERVER_LOG", "shootistlog.txt"); + + // Drop the client connection after we are done with the + // transaction. + properties.setProperty("gov.nist.javax.sip.CACHE_CLIENT_CONNECTIONS", "false"); + // Set to 0 (or NONE) in your production code for max speed. + // You need 16 (or TRACE) for logging traces. 32 (or DEBUG) for + // debug + traces. + // Your code will limp at 32 but it is best for debugging. + properties.setProperty("gov.nist.javax.sip.TRACE_LEVEL", "DEBUG"); + if (System.getProperty("enableNIO") != null && System.getProperty("enableNIO").equalsIgnoreCase("true")) { + properties.setProperty("gov.nist.javax.sip.MESSAGE_PROCESSOR_FACTORY", + NioMessageProcessorFactory.class.getName()); + } + try { + // Create SipStack object + sipStack = sipFactory.createSipStack(properties); + System.out.println("createSipStack " + sipStack); + } catch (PeerUnavailableException e) { + // could not find + // gov.nist.jain.protocol.ip.sip.SipStackImpl + // in the classpath + e.printStackTrace(); + System.err.println(e.getMessage()); + fail("Problem with setup"); + } + + try { + headerFactory = sipFactory.createHeaderFactory(); + addressFactory = sipFactory.createAddressFactory(); + messageFactory = sipFactory.createMessageFactory(); + udpListeningPoint = sipStack.createListeningPoint(myAddress, myPort, "udp"); + sipProvider = sipStack.createSipProvider(udpListeningPoint); + Shootist listener = this; + sipProvider.addSipListener(listener); + + String badRequest = "INVITE sip:LittleGuy@127.0.0.1:5070 SIP/2.0\r\n" + + "Call-ID: 7a3cd620346e3fa199cb397fe6b6fc16@127.0.0.1\r\n" + + "CSeq: 1 INVITE\r\n" + + "From: \"The Master Blaster\" ;tag=12345\r\n" + + "To: \"The Little Blister\" \r\n" + + "Via: SIP/2.0/UDP 127.0.0.1:5070 ;branch=z9hG4bKba9abfef1063941840d955a5e3e7dae0393734\r\n" + + "Max-Forwards: 70\r\n" + + "Content-Length: 0\r\n\r\n"; + + System.out.println("Parsing message \n" + badRequest); + Request request = null; + try { + request = messageFactory.createRequest(badRequest); + } catch (ParseException ex) { + System.out.println("Unexpected exception " + ex); + fail("Unexpected exception"); + } + + // send the request out. + sipProvider.sendRequest(request); + + } catch (Exception ex) { + ex.printStackTrace(); + fail("cannot create or send initial invite"); + } + } + + public void terminate() { + this.sipStack.stop(); + } + } + + private Shootist shootist; + + @Override + public void setUp() { + this.shootist = new Shootist(); + } + + @Override + public void tearDown() { + shootist.terminate(); + } + + public void testSendInviteWithoutContactHeader() { + this.shootist.init(); + try { + Thread.sleep(500); + } catch (Exception ex) { + } + + assertTrue("Should see TransactionUnavailableException", shootist.sawTransactionUnavailableException); + assertTrue("Should see 400 Bad Request response", shootist.sawBadRequestResponse); + } +}