Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null input throws unhandled exception in InputConverter #27

Open
JayPerfetto opened this issue Jun 20, 2020 · 0 comments
Open

Null input throws unhandled exception in InputConverter #27

JayPerfetto opened this issue Jun 20, 2020 · 0 comments

Comments

@JayPerfetto
Copy link

You should add the following line to InputConverter before trying to parse the input as an int:

  if (str == null) return Left(InvalidInputFailure());

otherwise an unhandled exception is thrown that is not covered in your exception handling.
lukechi1219 added a commit to lukechi1219/flutter-tdd-clean-architecture-course that referenced this issue Jun 21, 2020
@lukechi1219
fix ResoCoder/issues/27
c3e94ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JayPerfetto