Skip to content

[DISCUSSION] Re-using posts, post pages #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahmoudajawad opened this issue Apr 25, 2022 · 1 comment
Open

[DISCUSSION] Re-using posts, post pages #3

mahmoudajawad opened this issue Apr 25, 2022 · 1 comment

Comments

@mahmoudajawad
Copy link

Hello.

Thank you for sharing this project and associated tutorial with us.

The end-results of your project doesn't match most of the structures I use in mobile. To stress here, this is because I'm used to specific app structure inherited from previous projects, rather than short-coming on your work. I tried to build on your work to find how I can implement the following:

  • Accessing user's posts without using navigateTo which would jump the current user across tabs.
  • Getting to access post page from anywhere in the app, using one route only.

The first was quite straight-froward; I simply converted single-user route to a parent route including a child for posts route. Re-build, re-run and now I can get to access user's posts from his profile page.

Second point was more tricky. No matter what I did in attempt to push the same named route in current tab, I yielded errors. Lastly, I tried a behaviour that is common in react-native apps, which is keeping common pages as root-based routes, in which it results in the page covering the whole screen when navigated to from any page. I had to add an app-bar to get the back button. This worked, though this is not the end-results I would wish for.

Now, I want to hear your opinion on these:

  • What do you think of this? Is this something that is prohibited in flutter-land for any reasons? Or, a welcome change?
  • If you ignore my changes, how would you implement the requirements I listed in the beginning?

Thanks again for your work and looking forward to discussing with you this topic.

@mahmoudajawad
Copy link
Author

I forgot to reference the changes I made:
mahmoudajawad@1ea7278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant