Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotations #196

Open
multimeric opened this issue Sep 23, 2024 · 3 comments
Open

Type annotations #196

multimeric opened this issue Sep 23, 2024 · 3 comments

Comments

@multimeric
Copy link

I rely pretty heavily on type annotations, and I envisage using ro-crate-py a lot in the near future. Would you be open to me submitting a PR that adds type annotations to the library?

If this is okay, could I bump the minimum Python version from 3.7 to 3.9? 3.7 has been EOL for a while, and 3.8 will be EOL just over a week: https://devguide.python.org/versions/. The reason this matters is that it unlocks better type syntax such as list[str].

@simleo
Copy link
Collaborator

simleo commented Sep 24, 2024

Would you be open to me submitting a PR that adds type annotations to the library?

OK, thank you!

could I bump the minimum Python version from 3.7 to 3.9

Already done that in #200

@dnlbauer
Copy link
Contributor

dnlbauer commented Feb 3, 2025

@multimeric are you still/yet working on this?

If not: I put some effort into getting type annotations to work for ro-crate-py. I will probably keep working on it from time to time: https://github.com/dnlbauer/ro-crate-py/tree/type_annotations

@multimeric
Copy link
Author

No I'm not. I made a start which you can feel free to look at, use or copy here: master...WEHI-SODA-Hub:ro-crate-py:typing.

However I ended up developing alternative approaches to this problem, which is why I never finished this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants