Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble implementing custom environment #224

Open
allenjeffreywu opened this issue Feb 23, 2024 · 3 comments
Open

Trouble implementing custom environment #224

allenjeffreywu opened this issue Feb 23, 2024 · 3 comments

Comments

@allenjeffreywu
Copy link

Hey team, I am having a tough time implementing CityLearn with MARLlib. I believe my first attempt was flawed. This is attempt number 2. I cannot get mappo to work with it, and it looks like I will have to edit the internals of MARLlib to make it work (which I want to avoid as MUCH as possible). My current issue is with action spaces in cc_mlp.py . My action space is a Gym Dict and the shape of it just never seems to work. I am curious about the opponent_actions input and what creates it, as well as ways to debug this without print statements. I am also curious as to the expected shape of opponent_actions_ls in the end before it is torch.cat()

Here is my repo:
https://github.com/allenjeffreywu/MARLlib_CityLearn2

Please take a look if possible or at least answer my questions to help with development. I hoped that MARLlib would be simple enough to implement but it looks like it isn't.

@Morphlng
Copy link

From what I understand, the observation space and action space in MARLlib is for a single agent, instead a dict for each agent. In other words, it does not support heterogeneous obs/action space.

@zxnga
Copy link

zxnga commented Jul 5, 2024

hey @allenjeffreywu I'm trying to work with the same environment as you, did you make it work ? i have troubles (see #239)

@allenjeffreywu
Copy link
Author

@TheoZan No, I did not get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants