Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agents moving between distant ranks in a SharedGrid #54

Closed
ncollier opened this issue Oct 5, 2023 · 2 comments
Closed

Agents moving between distant ranks in a SharedGrid #54

ncollier opened this issue Oct 5, 2023 · 2 comments
Assignees

Comments

@ncollier
Copy link
Member

ncollier commented Oct 5, 2023

"It seems that I am experiencing synchronization issues with agents. I believe that in certain cases, the agents may not be able to successfully change their ranks as they are moving through the shared grid. I would guess that the issue might be related to situations where the areas controlled by origin and destination ranks are far from each other."

Check that each rank, given a point, can determine the rank associated with that point. Perhaps can only determine adjacencent ranks using the MPI Cartesian topology.

@ncollier ncollier self-assigned this Oct 5, 2023
@ncollier
Copy link
Member Author

ncollier commented Oct 6, 2023

When agent moves, agent only becomes out of bounds if enters neighbors local_bounds. Need to update this check to check everyone -- start with neighbors and then check other ranks.

See distributed_space.h: 214+

When creating DistributedCartesianSpace -- get all ranks local bounds via MPI, after local bounds and neighbors is computed?

@ncollier
Copy link
Member Author

ncollier commented Oct 6, 2023

Now checks all rank local bounds after checking neighbors.

  • Test with Sandro's example
  • Check to make sure that the data in out_of_bounds_agents is being decreffed appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant