Skip to content

Commit 8f2a341

Browse files
committed
📝 update readme - addressing issue #19
1 parent 6faaa3c commit 8f2a341

File tree

2 files changed

+64
-5
lines changed

2 files changed

+64
-5
lines changed

.github/bug_report.md

+38
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is.
12+
13+
**To Reproduce**
14+
Steps to reproduce the behavior:
15+
1. Go to '...'
16+
2. Click on '....'
17+
3. Scroll down to '....'
18+
4. See error
19+
20+
**Expected behavior**
21+
A clear and concise description of what you expected to happen.
22+
23+
**Screenshots**
24+
If applicable, add screenshots to help explain your problem.
25+
26+
**Desktop (please complete the following information):**
27+
- OS: [e.g. iOS]
28+
- Browser [e.g. chrome, safari]
29+
- Version [e.g. 22]
30+
31+
**Smartphone (please complete the following information):**
32+
- Device: [e.g. iPhone6]
33+
- OS: [e.g. iOS8.1]
34+
- Browser [e.g. stock browser, safari]
35+
- Version [e.g. 22]
36+
37+
**Additional context**
38+
Add any other context about the problem here.

README.md

+26-5
Original file line numberDiff line numberDiff line change
@@ -10,42 +10,60 @@
1010
API specification for deploy the [detection models](https://github.com/RentadroneCL/model-definition/blob/master/README.md), this repository contains a performant, production-ready reference implementation.
1111

1212
## Documentation
13+
1314
See [https://rentadronecl.github.io/docs](https://rentadronecl.github.io/docs/detection-models) for tutorials and more guides.
1415

1516
## Developers
17+
1618
Help improve our software! We welcome contributions from everyone, whether to add new features, improve speed, fix existing bugs or add support. [Check our code of conduct](CODE_OF_CONDUCT.md), [the contributing guidelines](CONTRIBUTING.md) and how decisions are made.
1719

1820
Any code contributions are welcomed as long as they are discussed in [Github Issues](https://github.com/RentadroneCL/Web-API/issues) with maintainers. Be aware that if you decide to change something and submit a PR on your own, it may not be accepted.
1921

20-
#### Creating an issue
21-
You can open a new issue based on code from an existing pull request. For more information, see [the template for filling issues](https://github.com/RentadroneCL/Web-API/blob/master/.github/ISSUE_TEMPLATE/feature_request.md)
22+
### Creating an issue
23+
24+
To encourage active collaboration, we strongly encourages pull requests, not just bug reports. "Bug reports" may also be sent in the form of a pull request containing a failing test.
25+
26+
However, if you file a bug report, your issue should contain a title and a clear description of the issue. You should also include as much relevant information as possible and a code sample that demonstrates the issue. The goal of a bug report is to make it easy for yourself - and others - to replicate the bug and develop a fix. For more information, see the templates for filling issues.
27+
28+
| Template | Description | Example |
29+
| -------- | ------------|---------|
30+
| Feature request | Suggest an idea for this project | [template](https://github.com/RentadroneCL/Web-API/blob/master/.github/ISSUE_TEMPLATE/feature_request.md) |
31+
| Bug report | Create a report to help us improve | [template](https://github.com/RentadroneCL/Web-API/blob/master/.github/ISSUE_TEMPLATE/bug_report.md) |
32+
33+
Remember, bug reports are created in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the bug report will automatically see any activity or that others will jump to fix it. Creating a bug report serves to help yourself and others start on the path of fixing the problem. If you want to chip in, you can help out by fixing any bugs listed in our [issue trackers](https://github.com/RentadroneCL/Web-API/issues).
2234

2335
## Requirements
36+
2437
Python 3.6+
2538

2639
## Quickstart
40+
2741
In the root project execute the following command to install all dependencies project
2842

29-
```
43+
```bash
3044
pip install -r requirements.txt
3145
```
3246

33-
You will also need an ASGI server, for production such as <a href="http://www.uvicorn.org" class="external-link" target="_blank">Uvicorn</a> or <a href="https://gitlab.com/pgjones/hypercorn" class="external-link" target="_blank">Hypercorn</a>.
47+
You will also need an ASGI server, for production such as [Uvicorn](http://www.uvicorn.org) or [Hypercorn](https://gitlab.com/pgjones/hypercorn).
3448

3549
```bash
3650
pip install uvicorn
3751
```
3852

3953
## Configuration
54+
4055
### Configuration Files
56+
4157
All of the configuration files for the API are stored in the `config` directory. Each option is documented, so feel free to look through the files and get familiar with the options available to you.
4258

4359
### Application Key
60+
4461
The next thing you should do after installing is set your application key to a random string.
4562

4663
Typically, this string should be 32 characters long. The key can be set in the `.env` environment file. If you have not copied the `.env.example` file to a new file named `.env`, you should do that now. If the application key is not set, your user sessions and other encrypted data will not be secure!
4764

4865
### Model Configuration
66+
4967
The model that we are going to deploy is for predicting photovoltaic fault. You can get the data [here](https://drive.google.com/drive/folders/1LSc9FkAwJrAAT8pAUWz8aax_biFAMMXS?usp=sharing).
5068

5169
| Model | Weights Trained | Config |
@@ -60,6 +78,7 @@ The model that we are going to deploy is for predicting photovoltaic fault. You
6078
We start by loading the data and compiled models into the `storage/model` folder and the configuration files for each model in the `storage/config` folder and saving the names of the features that we want to use in our model.
6179

6280
### Example model configuration file
81+
6382
```js
6483
{
6584
"model": {
@@ -74,7 +93,7 @@ We start by loading the data and compiled models into the `storage/model` folder
7493

7594
After we have prepared the data and saved all necessary files it is time to start creating the API to serve our model from.
7695

77-
**NOTE:** There are several methods for saving a model, each with its own sets of pros and cons you may change in function of your necesities.
96+
**NOTE:** There are several methods for saving a model, each with its own sets of pros and cons you may change in function of your necessity.
7897

7998
### Run it
8099

@@ -103,6 +122,7 @@ You already created an API that:
103122
* If the mimetype does not indicate JSON `application/json` this returns `None`.
104123

105124
### Example of an input data
125+
106126
```js
107127
[
108128
{
@@ -137,6 +157,7 @@ You already created an API that:
137157
```
138158

139159
### Viewing Results
160+
140161
```js
141162
[
142163
{

0 commit comments

Comments
 (0)