Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want change file 'ProjectZomboid64.json' #38

Open
w0330t opened this issue Aug 17, 2022 · 1 comment
Open

I want change file 'ProjectZomboid64.json' #38

w0330t opened this issue Aug 17, 2022 · 1 comment

Comments

@w0330t
Copy link

w0330t commented Aug 17, 2022

I want to add a line to the file "-Duser.language=cn",
But I restart docke this file will create
I just want user this mod
Please what should i do

@Renegade-Master
Copy link
Owner

Hello!

Sorry for the delayed response.

This is because I overwrite the directory. I shouldn't really do that, and I intend to fix this issue next.

This affects your issue and #23.

ryphon added a commit to ryphon/zomboid-dedicated-server that referenced this issue Sep 26, 2022
https://theindiestone.com/forums/index.php?/topic/47417-dedicated-server-on-linux-vps-jre-crashes/

Only way to keep my server stable with 10+ people is to set to G1GC, but there's other java jre gc options

Afaik there's only a few java GC's that'd matter. ZGC is usually best, but G1GC can sometimes be more efficient with it's RAM usage. Probably related to something dumb in either my vm configs or otherwise, but seems like an easy change to allow it to be configurable more generally.

Maybe just adds tech debt to potential future work to deal with Renegade-Master#38 and Renegade-Master#23 but idk, this is an easy fix for my specific problems.

Signed-off-by: Dylan Shepard <[email protected]>
Renegade-Master pushed a commit to ryphon/zomboid-dedicated-server that referenced this issue Nov 1, 2022
https://theindiestone.com/forums/index.php?/topic/47417-dedicated-server-on-linux-vps-jre-crashes/

Only way to keep my server stable with 10+ people is to set to G1GC, but there's other java jre gc options

Afaik there's only a few java GC's that'd matter. ZGC is usually best, but G1GC can sometimes be more efficient with it's RAM usage. Probably related to something dumb in either my vm configs or otherwise, but seems like an easy change to allow it to be configurable more generally.

Maybe just adds tech debt to potential future work to deal with Renegade-Master#38 and Renegade-Master#23 but idk, this is an easy fix for my specific problems.

Signed-off-by: Dylan Shepard <[email protected]>
Renegade-Master added a commit that referenced this issue Nov 2, 2022
* allow for garbage collection algo preference

https://theindiestone.com/forums/index.php?/topic/47417-dedicated-server-on-linux-vps-jre-crashes/

Only way to keep my server stable with 10+ people is to set to G1GC, but there's other java jre gc options

Afaik there's only a few java GC's that'd matter. ZGC is usually best, but G1GC can sometimes be more efficient with it's RAM usage. Probably related to something dumb in either my vm configs or otherwise, but seems like an easy change to allow it to be configurable more generally.

Maybe just adds tech debt to potential future work to deal with #38 and #23 but idk, this is an easy fix for my specific problems.

Signed-off-by: Dylan Shepard <[email protected]>

* readme updates

* updating docker-compose, fixing src/run-server reference

* Update GC Env RegEx pattern;

Signed-off-by: Renegade-Master <[email protected]>

* Add test for new GC;

- .github/workflows/docker-build.yml
  - Add environment configuration for new GC Config option.
  - Add Test for new configuration option.

- README.md
  - Formatting pass.

- docker-compose.yaml
  - Formatting pass.

* Correct GC Config replacement;

* Minor correction;

* Correct sed replacement;

Signed-off-by: Dylan Shepard <[email protected]>
Signed-off-by: Renegade-Master <[email protected]>
Co-authored-by: Renegade-Master <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants