Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISC-V support #496

Open
tingsi5 opened this issue Jul 26, 2024 · 0 comments
Open

Add RISC-V support #496

tingsi5 opened this issue Jul 26, 2024 · 0 comments

Comments

@tingsi5
Copy link

tingsi5 commented Jul 26, 2024

We have an Embree RISC-V port based on sse2rvv [1] for a project that uses SCons as the build system. If we would like to contribute it back to the Embree project, what's the proper way to add it to the build system?

In CMakeList.txt, it checks CMAKE_SYSTEM_PROCESSOR to set EMBREE_ARM for aarch64 [2], which seems to expect building Embree on the same architecture. Is this a convention that needs to follow? Or it's CMAKE_TOOLCHAIN_FILE to use for cross-compiling, or are there any other options you'd suggest? Thank you.

[1] https://github.com/pattonkan/sse2rvv
[2]

embree/CMakeLists.txt

Lines 238 to 240 in 0c236df

ELSEIF(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "ARM64")
MESSAGE(STATUS "Building for AArch64")
SET(EMBREE_ARM ON)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant