fix bug in markup parser whenever the same attribute appears twice

RemiEven · Jan 28, 2024 · e293537 · e293537
1 parent b9f6f20
commit e293537
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/markup/line_parser.go b/markup/line_parser.go
@@ -191,7 +191,7 @@ func (lineParser *LineParser) buildAttributesFromMarkers(markers []attributeMark
 			}
 
 			matchedOpenMarker := unclosedMarkers[matchedOpenMarkerIndex]
-			unclosedMarkers = slices.Delete(unclosedMarkers, matchedOpenMarkerIndex, matchedOpenMarkerIndex)
+			unclosedMarkers = slices.Delete(unclosedMarkers, matchedOpenMarkerIndex, matchedOpenMarkerIndex+1)
 
 			length := marker.position - matchedOpenMarker.position
 			attribute := Attribute{

diff --git a/markup/line_parser_test.go b/markup/line_parser_test.go
@@ -29,6 +29,28 @@ func TestLineParser(t *testing.T) {
 				},
 			},
 		},
+		"attribute appearing twice": {
+			input: `Oh, [wave]hello[/wave] [wave](twice)[/wave] there!`,
+			expectedResult: &ParseResult{
+				Text: `Oh, hello (twice) there!`,
+				Attributes: []Attribute{
+					{
+						Name:           "wave",
+						Position:       4,
+						SourcePosition: 4,
+						Length:         5,
+						Properties:     map[string]Value{},
+					},
+					{
+						Name:           "wave",
+						Position:       10,
+						SourcePosition: 23,
+						Length:         7,
+						Properties:     map[string]Value{},
+					},
+				},
+			},
+		},
 		"overlapping attributes": {
 			input: `Oh, [wave]hello [bounce]there![/bounce][/wave]`,
 			expectedResult: &ParseResult{