Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue: animation and gesture inheritance to all children #28

Open
ReinBentdal opened this issue Feb 18, 2020 · 0 comments
Open

Comments

@ReinBentdal
Copy link
Owner

styled_widget uses InheritedWidget to pass animations down to children. This means defined animations in one Widget is passed down to all later children of the widget.

styled_widget also uses InheritedWidget for gestures to make the ripple method possible with InkWell. If onTap isnt inherited from GestureDetector the method wont trigger. Therefore all later children with a ripple method will inherit the onTap method. This can maybe be fixed by implementing some logic in the InheritedWidget which only allows two children (GestureDetector and one InkWell) to access the method

@ReinBentdal ReinBentdal added the bug Something isn't working label Feb 18, 2020
@ReinBentdal ReinBentdal removed the bug Something isn't working label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant