Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunter's Yaml-CPP Version Can't Compile In VS2017 #116

Open
MatthewJM96 opened this issue Aug 15, 2018 · 9 comments
Open

Hunter's Yaml-CPP Version Can't Compile In VS2017 #116

MatthewJM96 opened this issue Aug 15, 2018 · 9 comments

Comments

@MatthewJM96
Copy link
Member

We need to keep an eye on yaml-cpp for its next release. When it releases we then need to get Hunter to accept that new version as an option for building with. This will enable compilation on VS2017.

Alternatively, we could heed the issues raised by Cristian in this issue and look for an alternative yaml solution.

@czaloj
Copy link
Contributor

czaloj commented Aug 16, 2018

Yeah, I don't remember what the exact problem was with it :/

@caseymcc
Copy link
Collaborator

or better yet who needs yaml, I will gladly replace it with json

@caseymcc
Copy link
Collaborator

In fact, I have already been working on python scripts to convert the current texture yaml files to json, for my needs.

@Barnold1953
Copy link
Contributor

+1 for json

@MatthewJM96
Copy link
Member Author

Did we not prefer YAML for the ease of understanding for modders and designers? If it makes life significantly easier then JSON gets a +1 from me on that reason, but as it stands yaml-cpp is only preventing compilation on VS2017 due to a single macro - could we not make a request to the yaml-cpp guys to back-propagate their hotfix for that to a new minor release for 0.5?

@MatthewJM96
Copy link
Member Author

I definitely prefer the yaml format on grounds of the end-user.

@Barnold1953
Copy link
Contributor

yeah we picked YAML for ease of use, and robustness. It is probably better for our needs so if we have a reliable parsing alternative or a way to fix this then its ideal.

@MatthewJM96
Copy link
Member Author

I'll make a PR with the yaml-cpp guys/get in touch with them, however they prefer, we can come back to thinking about changing after we know how easy they make it for us to get what we need.

@bryan-lunt
Copy link

Also cant compile on MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants