Skip to content

Commit e931548

Browse files
committed
comment ping changes + update redissuite skip test list/comments
1 parent 0eeddad commit e931548

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/commands.c

+2-3
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,8 @@ static const CommandSpec commands[] = {
7272

7373
/* Admin commands - bypassed */
7474
{"auth", CMD_SPEC_DONT_INTERCEPT },
75-
/* queued by multi, need to intercept */
76-
// {"ping", CMD_SPEC_DONT_INTERCEPT },
77-
{"ping", CMD_SPEC_READONLY },
75+
/* queued by multi, need to intercept in multi, but can't do that right now with redis */
76+
{"ping", CMD_SPEC_DONT_INTERCEPT },
7877
{"hello", CMD_SPEC_DONT_INTERCEPT },
7978
{"module", CMD_SPEC_DONT_INTERCEPT },
8079
{"config", CMD_SPEC_DONT_INTERCEPT },

tests/redis-suite/skip.txt

+8-5
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ UNLINK can reclaim memory in background
4141
-- ACL test fails because we prepend "raft" string to the command
4242
Script ACL check
4343

44-
4544
-- MULTI/EXEC is currently read-write in RedisRaft
4645
EXEC with only read commands should not be rejected when OOM
4746

@@ -52,10 +51,14 @@ EXEC with only read commands should not be rejected when OOM
5251
MULTI with SAVE
5352
MULTI with SHUTDOWN
5453
MULTI with config error
55-
56-
-- pubsub can't allow ping to be intercepted, but needs to be intercepted for multi tests
57-
-- where part of the multi response
58-
/.*Sub PING on.*
54+
-- same as above, but these all relate to PING usage inside of MULTI
55+
MULTI / EXEC basics
56+
EXEC works on WATCHed key not modified
57+
After successful EXEC key is no longer watched
58+
After failed EXEC key is no longer watched
59+
It is possible to UNWATCH
60+
FLUSHALL does not touch non affected keys
61+
FLUSHDB does not touch non affected keys
5962

6063
-- After fixing this: https://github.com/RedisLabs/redisraft/issues/367
6164
-- We don't need to skip this test as it doesn't actually configure a replica.

0 commit comments

Comments
 (0)