Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build RedisAI from Source - bash get_deps.sh #743

Open
esandoval30 opened this issue May 12, 2021 · 7 comments
Open

Unable to build RedisAI from Source - bash get_deps.sh #743

esandoval30 opened this issue May 12, 2021 · 7 comments
Assignees

Comments

@esandoval30
Copy link

Describe the bug
Following Build instructions here https://oss.redislabs.com/redisai/quickstart/

The command bash get_deps.sh fails with "There are errors"

To Reproduce
Steps to reproduce the behavior:

  1. git clone --recursive https://github.com/RedisAI/RedisAI
  2. cd RedisAI
  3. bash get_deps.sh

Observed error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: macs
  • Version Catalina 10.15.7
  • Platfrom [e.g. x64-86, Jetson, ARM]
  • Runtime CPU

Additional context
The issue is likely to be related to ONNXRuntime version v1.7.1 and the fact that there is no tgz on https://github.com/microsoft/onnxruntime/releases for this version and platform combination

1.7.0 does appear to list tgz for every supported platform in the format expected by bash get_deps.sh

@chayim chayim self-assigned this May 12, 2021
@chayim
Copy link
Contributor

chayim commented May 12, 2021

Hi @esandoval30, thank you for reporting this! From what branch were you build?

Please note - we're in the middle of updating our OSX support.

@esandoval30
Copy link
Author

Good to hear osx support is being updated

Re:branch. I just cloned "git clone --recursive https://github.com/RedisAI/RedisAI"

@chayim
Copy link
Contributor

chayim commented May 12, 2021

@esandoval30 Thanks, one final question. Are you on an M1, or x86 mac hardware?

@esandoval30
Copy link
Author

processor = 2.4 GHz 8-Core Intel Core i9

@chayim
Copy link
Contributor

chayim commented May 12, 2021

Awesome, thanks for the information!

@Spartee
Copy link
Contributor

Spartee commented Jun 3, 2021

We have seen this issue on our side as well for MacOS on intel. After investigation it seemed to be a dead link to the onnx runtime (as y'all are using a vendored version with a custom memory allocator now I believe)

@PaulRudin
Copy link

This currently fails on M1 mac. In a number of places it seems that the get_deps.sh script assumes that if the os is macos then the architecture is x86_64, which presumably shouldn't be the case on M1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants