Check subs before start

[Rocco83]

The script should check the subs validity before start.

[evgeni]

Makes sense, yeah.

There is already a storage we use for the quantity (to not talk to the API all the time): https://github.com/RedHatSatellite/katello-attach-subscription/blob/master/katello-attach-subscription#L90
The population of the data structure could be done upfront, instead of on the fly.
What do you think?

[Rocco83]

I agree.

Moving on a little bit,
Based on #7

This is the current code that populate subs:
https://github.com/Rocco83/katello-attach-subscription/blob/203ba5e286ed3f297ddd59849cd8ebd3b3ed7a2b/katello-attach-subscription#L287

Short TODO:

1. from YAML take only the key we need (subkey of sub: key https://github.com/Rocco83/katello-attach-subscription/blob/master/katello-attach-subscription.yaml-example#L12)
2. flatten the data of YAML, removing duplicated subscriptions
3. iterate the flatten data

Failing condition:

• sub retrieval fail. This should be splitted in which condition we have (missing sub, general error, ...). But 400 general error is returned as now.

Current proposal:

1. iterate across all of subscription and track the failed one. do not fail immediately in case of sub retrival failure.
2. if only one sub fail, report all failed subscription suggesting to check the sub

Reverting to you, what do you think?

[evgeni]

@Rocco83 correct me, but I think this was part of #26?