From 1de0831b17818b1c0b0fb6d16c9cbba0cd066ae8 Mon Sep 17 00:00:00 2001
From: Georgii Karataev <georgkarat@gmail.com>
Date: Wed, 9 Oct 2024 11:43:48 +0200
Subject: [PATCH] fix: Remove defaullt value for https while creating a config

---
 packages/config/src/lib/config.test.js  | 2 +-
 packages/config/src/lib/createConfig.ts | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/config/src/lib/config.test.js b/packages/config/src/lib/config.test.js
index d4a432eb3..a1dac7b76 100644
--- a/packages/config/src/lib/config.test.js
+++ b/packages/config/src/lib/config.test.js
@@ -44,7 +44,7 @@ describe('should create dummy config with no options', () => {
       static: {
         directory: '/dist',
       },
-      server: 'https',
+      server: 'http',
       host: '0.0.0.0',
       port: 8002,
       hot: false,
diff --git a/packages/config/src/lib/createConfig.ts b/packages/config/src/lib/createConfig.ts
index a26b7cbe6..3b8e2aee1 100644
--- a/packages/config/src/lib/createConfig.ts
+++ b/packages/config/src/lib/createConfig.ts
@@ -62,7 +62,7 @@ export const createConfig = ({
   publicPath,
   appEntry,
   rootFolder,
-  https = true,
+  https,
   mode,
   appName,
   useFileHash = true,
@@ -274,7 +274,7 @@ export const createConfig = ({
         directory: `${rootFolder || ''}/dist`,
       },
       port: devServerPort,
-      server: _unstableSpdy ? 'spdy' : https ? 'https' : 'http',
+      server: _unstableSpdy ? 'spdy' : https || Boolean(useProxy) ? 'https' : 'http',
       host: '0.0.0.0', // This shares on local network. Needed for docker.host.internal
       hot: internalHotReload, // Use livereload instead of HMR which is spotty with federated modules
       liveReload: !internalHotReload,