Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__eq__ implementation for Notification class #599

Open
azhou95 opened this issue Feb 11, 2022 · 1 comment
Open

__eq__ implementation for Notification class #599

azhou95 opened this issue Feb 11, 2022 · 1 comment

Comments

@azhou95
Copy link

azhou95 commented Feb 11, 2022

The eq magic method for the Notification class seems to be implemented as a comparison of the two sides of the equality being casted to string.

This can lead to strange behaviour such as: OnNext(1.0) == OnNext("1.0") being evaluated as True.

Would it be possible to improve this behaviour?
@dbrattli
Copy link
Collaborator

You could try. Feel free to make a PR.

@matiboy matiboy mentioned this issue Jun 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbrattli @azhou95