Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing termination time in SA if not defined in the RMG reactor #76

Open
alongd opened this issue Mar 13, 2022 · 0 comments
Open

Missing termination time in SA if not defined in the RMG reactor #76

alongd opened this issue Mar 13, 2022 · 0 comments

Comments

@alongd
Copy link
Member

alongd commented Mar 13, 2022

While it's legal to define an RMG reactor w/o a termination time, running SA (at least via the CanteraConstantTP adapter) does expect to have a run time that is taken from the reactor's termination time.

Suggestion: After an RMG run, read the chemical run time from RMG and assign it to the termination time if the latter is None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant