Property based convergence criteria #2526
mjohnson541
started this conversation in
Ideas
Replies: 2 comments
-
What's an example of a property that someone might want to use as a convergence criteria? |
Beta Was this translation helpful? Give feedback.
0 replies
-
First coming to mind: Ignition delay, concentration of a species (at a given time or range of times), thermodynamic variables (T,P etc. at a given time or range of times) for catalysis probably the TOF. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I was looking back at issue #2521 and thought to myself, why don't we decide if an RMG model is converged based on the convergence of properties the user chooses automatically? I think part of the the old reason is that RMG only had a very limited set of reactors (couldn't do this for ignition delay for example), which isn't as much of an issue anymore with the RMS reactors.
The design isn't trivial...you definitely don't want to stop the first iteration a property doesn't change, but as this is in practice how we decide if RMG runs are converged it should be highly practical to just have RMG do this automatically.
Beta Was this translation helpful? Give feedback.
All reactions