Commented out the reset of the job_dict conformers #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 73.04% 73.05% +0.01%
==========================================
Files 99 99
Lines 26191 26190 -1
Branches 5484 5484
==========================================
+ Hits 19131 19133 +2
+ Misses 5697 5695 -2
+ Partials 1363 1362 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
calvinp0
force-pushed
the
632-receiving-keyerror-3-during-arc-restart
branch
from
9f5be31
to
2bdc254
Compare
|
I think we assume that if we're in Does commenting this out solve the reset issues? I'd like to understand it better, but if so, please remove the line instead of commenting it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current workaround is to remove the reset of the self.job_dict[label]['conformers']
@alongd was there a specific reason for this line of code originally?