-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube - Theme): Android 8.0 dark mode startup crash #4536
Comments
You are patching and installing a split apk. Splits can only be mounted. |
i don't believe so, it is this apk |
I also tried with the manager to the same result |
|
Here are the results. I edited out the long processes with no visual changes. |
The crash is coming from YouTube code. Does unpatched 19.47.53 work? Are you using an emulator or an oddball device? Also try patching 19.16.39. |
You selected the installed app, which can be a split APK. Select a full APK from storage, or install it beforehand. |
the installed app was from the above apk saved in storage. it launches correctly when unpatched:
It's a galaxy note 8, just being mirrored with scrcpy. behaves the same with and without it.
here is the log for a patched 19.16.39 |
But the video you posted shows you selected the app from the installed apps, which can cause issues if not using root install. You should use the 'storage' button at the bottom of the screen. |
I did that way and produces the same: |
also, the patch for 19.16.39 did warn: |
That patch is not compatible with 19.16.39, which is expected. The error log still makes no sense. it shows a crash coming from YouTube code. Try patching with only |
I'll mention that 19.16.39 does at least show the youtube logo before crashing. and it looks like I used patch 5.12.0 on that previously, here is 5.13.0, not that it looks any different to me
|
If only GmsCore support works, then keep repatching with more patches until the issue returns. Use binary search to speed up repatching. Report back which patch causes the issue. |
I'm unfamiliar, can you point me to a resource? otherwise I was just going to make a shell for loop that compiles them all individually |
I've identified
as a culprit. applying just theme and gms support causes a crash. |
Are you using any patch options? It might be related to #2811 |
my full command is: |
I've confirmed a workaround for me. after installing, the app must be run without night mode on at least once. then the app launches normally. using full default patches: |
Can you reproduce the bug now again? What if you clear app data? |
yes, if I clear the youtube app data it bugs again until I turn off night mode. |
In this case we need to debug the patch and see what specifically in there breaks the app. Alternatively, you could try using older patches and see when the bug was introduced, narrowing down the exact release that introduced the patch |
I'll try that. otherwise, how effective is debugging without root? |
Fairly, but not efficient. We'd need to build the patches with some changes and see if they fix your issue. I'd like to do that if using older patches doesn't work. In that case please reach out to [email protected] for further instructions. |
this release is the regression: |
That commit fixed the status bar not using the splash screen dark theme color. Need to compare the XML files it's modifying and see the changes before/after patching. It might be modifying XML attributes it should not be. |
I think this is the temp file after patching: I can't seem to find where it is or what it looks like prior |
The change that caused the issue was to fix #4160 I reverted that fix and instead modified the prior design with 741c2d5 The status and nav bar white color issue is still fixed, but I cannot verify the app crash because the Android 8.0 emulator does not support app dark mode. Android 9 natively supports dark mode but does not crash. The issue must be specific to Samsung Android 8.0 dark mode. @bitingsock You can verify if it's fixed with the latest dev release. |
fix works great. good work! thank you! |
Bug description
App immediately crashes at launch, before showing anything.
Error logs
Solution
No response
Additional context
microg installed
patch for non-root succeeded, built, and installed with both CLI v5.0.0 and v5.0.1-dev.1
using patches-v5.13.0.rvp and patches-v5.12.0.rvp against youtube-v19.47.53 and v19.46.42
-jar cli.jar patch -p patches.rvp --out=out1.apk yt.apk
Acknowledgements
The text was updated successfully, but these errors were encountered: