Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Hide layout components): Hide horizontal shelves hides contents of explore sections #4234

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Dec 28, 2024 · 7 comments · Fixed by #4540
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications
Copy link
Contributor

ILoveOpenSourceApplications commented Dec 28, 2024

Bug description

Image

Image

Error logs

Solution

No response

Additional context

No response

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Dec 28, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Dec 28, 2024

Whitelisting movie_card.eml might fix it.

Edit: movie_card appears after the shelf has been created, and can't be a whitelist.

@0xrxL
Copy link

0xrxL commented Dec 28, 2024

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title bug(YouTube - Hide layout components): Hide horizontal shelves hides contents of Movies/Film section bug(YouTube - Hide layout components): Hide horizontal shelves hides contents of Movies/Film section and Courses/Learning section Jan 8, 2025
@ILoveOpenSourceApplications
Copy link
Contributor Author

ILoveOpenSourceApplications commented Jan 8, 2025

Also, there's lot of gray separator in the News section and due to Hide horizontal shelves hiding the contents, there's thick gray bars now instead.

Screenshots

Image
Image

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title bug(YouTube - Hide layout components): Hide horizontal shelves hides contents of Movies/Film section and Courses/Learning section bug(YouTube - Hide layout components): Hide horizontal shelves hides contents of YouTube sections Jan 8, 2025
@LisoUseInAIKyrios
Copy link
Contributor

Fixed with 62a6164

@LisoUseInAIKyrios LisoUseInAIKyrios linked a pull request Mar 7, 2025 that will close this issue
1 task
@ILoveOpenSourceApplications
Copy link
Contributor Author

It's not specific to Movies/Courses but actually any of the Explore pages.

On a side note, should the Hide gray separators be restored given that now people can set any of these pages as their start page and they will see gray separators if done so?

@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title bug(YouTube - Hide layout components): Hide horizontal shelves hides contents of YouTube sections bug(YouTube - Hide layout components): Hide horizontal shelves hides contents of explore sections Mar 7, 2025
@LisoUseInAIKyrios
Copy link
Contributor

The same fix also works for the explore page (it hides shelves if the back button and not the search bar is present).

@LisoUseInAIKyrios
Copy link
Contributor

I'm not seeing the huge grey dividers shown in the screenshot you posted. I think it was horizontal shelves being hidden that should not have been, and multiple dividers were left over and stacked up.

The last commit fixed that and the news shelves now show, and the divider is the correct size.

I don't think the dividers are annoying enough to add another setting, especially since the dividers only show in some areas buried in the explore tab. Can always use a custom filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants