bug(YouTube - Hide Shorts components): 'Hide navigation bar' hides it everywhere until restart

[MarcaDian]

Bug description

Steps:

1. Turn on ReVanced - Shorts - Hide navigation bar
2. Go to Shorts
3. Go back to the main page
4. Navigation bar will disappear

Navigation bar will return if Playback on feed is enabled or any video is open.

Screenrecorder-2024-09-16-13-43-49-354.mp4

MIUI 13, A12, Redmi 9 4/64
Patches 4.13.3
19.16.39, 19.34.42 (on last PR #3629)

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[zainarbani]

Have you tried to change the phone language to english or use vpn (i wonder if this is coutry specific a/b test)?

[oSumAtrIX]

The issue is reproducible, the hooks don't check properly if shorts are currently playing I assume

[MarcaDian]

Have you tried to change the phone language to english or use vpn (i wonder if this is coutry specific a/b test)?

Tried to test your proposal, and got a small bug (navigation does not disappear immediately, but flashes once and then disappears).
Test on 19.34.42

Edit: If then open any video and go back, the navigation bar returns.

Screenrecorder-2024-09-16-15-03-47-959.mp4

[MarcaDian]

I suggest that this option not be enabled by default, at least while searching for a solution.
New users who have the same issue as me may be confused. (It is currently enabled after a clean install)

[MarcaDian]

Also noticed that the navigation bar returns if Playback on feed is enabled or open any video.
(I always turn off Playback on feed)

[LisoUseInAIKyrios]

If the issue is fixed after restarting (and does not happen anymore), then saving the setting to a boolean static field should fix it:

private static boolean HIDE_SHORTS_NAVIGATION_BAR = Settings.HIDE_SHORTS_NAVIGATION_BAR.get()

https://github.com/ReVanced/revanced-integrations/blob/9e11ba11d9f40fb3bbc90404bf96c94c12e7b0ba/app/src/main/java/app/revanced/integrations/youtube/patches/components/ShortsFilter.java#L350-L357

[LisoUseInAIKyrios]

Even after restarting it happens again, at least for me. Also if I scroll through the feed for a bit (no need for vid to autoplay) the navigation bar comes back.

Do you have your start page changed to Shorts? Or did Shorts resume on app startup?

[MarcaDian]

No.
I try your last commit ReVanced/revanced-integrations@32b189e , doesn't work 😔

Screenrecorder-2024-09-18-23-08-39-303.mp4

[LisoUseInAIKyrios]

I'm trying 19.37, and the issue shows up there too. When exiting a Short the nav bar is hidden until a view is scrolled or search is opened.

Restarting doesn't change anything either.

[LisoUseInAIKyrios]

@MarcaDian Try again using the version bump branch. It's fixed for me.

[n1cKz1]

Do you have your start page changed to Shorts? Or did Shorts resume on app startup?

Nevermind lol, I seem to have misunderstood what you meant

[MarcaDian]

Yes, it works for me.

I want to note that very rarely after a cold start, the panel does not disappear in Shorts, but I think that this can be ignored (the second opening Shorts hides the panel), maybe I am looking for bugs too meticulously.

Screenrecorder-2024-09-19-10-26-38-862.mp4

also very hard to rewind, progress bar at the very bottom of the player

[LisoUseInAIKyrios]

also very hard to rewind, progress bar at the very bottom of the player

Yes the rewind at the bottom is an issue with builds after 19.16. I tried reducing the padding to the bottom view instead of removing it, but that breaks the nav bar if the user taps comments or any other action that shows the nav bar again.

Maybe the Shorts seekbar itself can be padded instead.

Edit: Padding issue is fixed by adjusting the hook and setting a padding height.