Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Store patch selection separately for each source #2198

Closed
3 tasks done
KobeW50 opened this issue Sep 8, 2024 · 4 comments
Closed
3 tasks done

feat: Store patch selection separately for each source #2198

KobeW50 opened this issue Sep 8, 2024 · 4 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Sep 8, 2024

Feature description

Currently, if a user saves a patch selection while using one patch source and then switches to a different source, the patch selection will only include the patches that share the same name as the selected patches from the first source.

Example: Imagine while using the ReVanced patches I set the patch selection for YouTube to include the Hide ads and Announcements patches. I then switch the source to inotia00's patches. The patch selection for YouTube will just be the Hide ads patch, instead of the Default patch selection or the patch selection I set the last time I used inotia00's patches.

Feature

Save the patch selection for each source separately. If a user switches to a source that has never been used, the default patches should be selected. If a user switches to a source that they have used in the past, the patch selection should be the same as what they left it as the last time they used this source.

When the Export patch selection option is used, the highest level of organization in the JSON should be the source.

Ideally, when the Import patch selection option is used, the manager should be backwards compatible with the old JSON format.

Motivation

The current behavior of the Manager is not intuitive and less useful than the proposed behavior in this request.

The use case is given in the example above.

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager.
@KobeW50 KobeW50 added the Feature request Requesting a new feature that's not implemented yet label Sep 8, 2024
@oSumAtrIX
Copy link
Member

Every patch will have it's selection distinctively by patch bundle in the compose version.

@Axelen123
Copy link
Member

Is this for flutter manager or compose?

@Ushie
Copy link
Member

Ushie commented Sep 8, 2024

Flutter

@KobeW50
Copy link
Contributor Author

KobeW50 commented Sep 9, 2024

It is aimed for the flutter manager, while it is still the main manager. IK priority has shifted to the compose manager, so if this festure request will not be completed for flutter, it can be closed as not planned.

@Ushie Ushie closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

4 participants