Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Patch option widgets move and leave value behind after their value is changed #2187

Open
4 tasks done
KobeW50 opened this issue Sep 2, 2024 · 0 comments
Open
4 tasks done
Labels
Bug report Something isn't working

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Sep 2, 2024

Bug description

When a patch has two or more text patch options, if you set one or more (but not all) patch options and then touch the screen outside the input area on the widget, the location of the patch option widgets will move. The topmost widgets with non-default input will move to the bottom of the list, and the empty widgets that were below will take their places and inherit the values.

I strongly recommend watching this recording with sound enabled (I narrate what I'm doing and what I'm trying to show):

YouCut_20240902_023837698.mp4

Steps to reproduce

  1. Open the patch option menu of a patch with two or more text patch options.

  2. Change the value of the topmost patch option.

  3. Tap anywhere on the screen (except a patch option textbox or toggle).

Expected behavior: Nothing should occur.

Actual behavior: The changed patch option widget will move to the bottom of the patch options list, and the next text-based widget in line that did not have its value changed will now have the value that you specified in step 2.

Logs

revanced-manager_logcat_20240902021851799653.log.txt

Version of ReVanced Manager and version & name of app you are patching

Manager 1.21.2

YouTube 19.16.39

ReVanced Manager logs

Uploaded above

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug is only related to ReVanced Manager.
@KobeW50 KobeW50 added the Bug report Something isn't working label Sep 2, 2024
@KobeW50 KobeW50 changed the title bug: bug: Patch option widgets move and leave value behind after their value is changed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant