Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Discouraged usage of pre-release variant by setting debug flag on #2124

Open
validcube opened this issue Aug 8, 2024 · 4 comments
Open
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@validcube
Copy link
Member

Debug are known to be extremely laggy and should be use by someone experienced.

There are obvious downside to this

  • Less tester to test the pre-release version
@validcube validcube added the Feature request Requesting a new feature that's not implemented yet label Aug 8, 2024
@Ushie
Copy link
Member

Ushie commented Aug 9, 2024

Why do we want to discourage the user of pre-release? And why make it worse for those who actually need to use pre-release?

@oSumAtrIX
Copy link
Member

Pre releases should not be downloaded at all except by involved developers. It is not something the end user is suppose to see but by nature of GitHub and auditing reasons it is public for everyone which creates the false impression of it being meant for the end user.

I don't think the user will understand that they are using a pre release just because the debug flag is on and assume that's how the app is. Furthermore the debug flag is being abused here for a purpose it is not meant for.

The correct approach to this is to not have the user have to visit GitHub in the first place, a place meant for developer's or development purposes. Instead, ReVanced is supposed to abstract GitHub into something like we did with our website where our API uses GitHub to get the relevant files and provide them in a controlled fashion to the user. Here on the website, unlike on GitHub, the user is meant to be and since the website transforms GitHub in a way that suits the domain, pre releases for development purposes are excluded from being shown on the website.

@IntelCorei5-8350u
Copy link

It's probably possible just to keep the pre releases in github actions and never put it into releases page

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Aug 16, 2024

GitHub actions isnt intended to use as a releases source. Actions are pruned after a certain time, cant be tagged or have a release note, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants