Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Restore the rustfmt.toml file #13

Closed
jelni opened this issue Jul 12, 2022 · 5 comments · Fixed by #14
Closed

Restore the rustfmt.toml file #13

jelni opened this issue Jul 12, 2022 · 5 comments · Fixed by #14
Labels
released

Comments

@jelni
Copy link

jelni commented Jul 12, 2022 •
edited
Loading

rustfmt.toml was removed in #12

I do not agree with that decision. I listed my points in #10 (comment).
@oSumAtrIX
Copy link
Member

What is the problem with the default one? Doesn't it format according a standard too?

@jelni
Copy link
Author

jelni commented Jul 12, 2022

The removed config:

  • replaced CRLF line endings with LF,
  • formatted code examples in docs (if any),
  • grouped and sorted imports,
  • used consistent comment formatting,
  • and much more.

As you can see, by removing the config, the standard style is less enforced.

@jelni
Copy link
Author

jelni commented Jul 12, 2022

I can PR a new config and explain the purpose of each rule if you want.

@oSumAtrIX oSumAtrIX mentioned this issue Jul 12, 2022
Merged
@oSumAtrIX
Copy link
Member

I can PR a new config and explain the purpose of each rule if you want.

Please suggest in #14.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: revert removal of rustfmt ReVanced/revanced-discord-bot
2 participants
@oSumAtrIX @jelni