Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add signature checks #337

Open
3 tasks done
oSumAtrIX opened this issue Aug 8, 2024 · 0 comments
Open
3 tasks done

feat: Add signature checks #337

oSumAtrIX opened this issue Aug 8, 2024 · 0 comments
Labels
Feature request Requesting a new feature

Comments

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Aug 8, 2024

Feature description

Depends on ReVanced/revanced-library#61

A signature should accompany each patch file. This can be achieved via an ArgGroup. The current patch file option can be moved into an arg group accompanied by an optional signature option. The keyring can be supplied via an option next to the ArgGroug. If the signature is missing or invalid, the patch should abort. Another option can be added to skip signature checks. A warning should always be shown if the signature check failed or was skipped. Example:

java -jar cli.jar patch -b patches.rvp -s patches.rvp.asc -b patches2.rvp -k revanced.gpg

A new utility subcommand should be added regarding the signatures.

Motivation

Same as ReVanced/revanced-manager#2082

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@oSumAtrIX oSumAtrIX added the Feature request Requesting a new feature label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

1 participant