Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve precision/helpfulness of "at an earlier point" error message for selfrefok miss #6494

Open
MichaelChirico opened this issue Sep 12, 2024 · 0 comments

Comments

@MichaelChirico
Copy link
Member

error(_("It appears that at some earlier point, names of this data.table have been reassigned. Please ensure to use setnames() rather than names<- or colnames<-. Otherwise, please report to data.table issue tracker.")); // # nocov

@HughParsonage flagged that telling user "at an earlier point" "something happened" is not the most helpful error to see:

#6419 (comment)

#6419 adds a similar message in a different place. As pointed out by @aitap, the root cause (IINM in both cases) is R doing a shallow_duplicate(): #6419 (comment)

I believe that means there's no real way for us to fully prevent the user from getting their table into a broken state (which would make sense as a reason why we wanted to start tracking .internal.selfref in the first place long ago).

But armed with a more precise understanding of the underlying issue, we can probably give the user an easier time understanding what's gone wrong & what to do about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant