groupingsets handling int64 does not need workaround anymore

[jangorecki]

data.table/R/groupingsets.R

Lines 88 to 109 in b566822

	# workaround for rbindlist fill=TRUE on integer64 #1459
	int64.cols = vapply_1b(empty, inherits, "integer64")
	int64.cols = names(int64.cols)[int64.cols]
	if (length(int64.cols) && !requireNamespace("bit64", quietly=TRUE))
	stopf("Using integer64 class columns require to have 'bit64' package installed.") # nocov
	int64.by.cols = intersect(int64.cols, by)
	# aggregate function called for each grouping set
	aggregate.set = function(by.set) {
	r = if (length(.SDcols)) x[, eval(jj), by.set, .SDcols=.SDcols] else x[, eval(jj), by.set]
	if (id) {
	# integer bit mask of aggregation levels: http://www.postgresql.org/docs/9.5/static/functions-aggregate.html#FUNCTIONS-GROUPING-TABLE
	# 3267: strtoi("", base = 2L) output apparently unstable across platforms
	i_str = paste(c("1", "0")[by %chin% by.set + 1L], collapse="")
	set(r, j = "grouping", value = if (nzchar(i_str)) strtoi(i_str, base=2L) else 0L)
	}
	if (length(int64.by.cols)) {
	# workaround for rbindlist fill=TRUE on integer64 #1459
	missing.int64.by.cols = setdiff(int64.by.cols, by.set)
	if (length(missing.int64.by.cols)) r[, (missing.int64.by.cols) := bit64::as.integer64(NA)]
	}
	r
	}

#1459 has been resolved, therefore existing workaround can be removec

[Anirban166]

Is this still valid? (I see more work around that part being done for the file)

If it is still omittable, maybe add the OP's case as a test after removal:

require(bit64)
test(2296, merge(data.table(id = c(1, 2)), data.table(id = 1, value = as.integer64(1)), by = "id", all.x = TRUE), data.table(id = c(1, 2), value = c(as.integer64(1), NA_integer64)))

[jangorecki]

Afair this workaround was not removed there