Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust auto update system #29

Open
Pythonic-Rainbow opened this issue Jan 16, 2020 · 12 comments
Open

More robust auto update system #29

Pythonic-Rainbow opened this issue Jan 16, 2020 · 12 comments
Labels
discussion Discussions. question Further information is requested

Comments

@Pythonic-Rainbow
Copy link
Member

e.g. what to do if we update files other than main.py ?

@sbhadr sbhadr added discussion Discussions. question Further information is requested labels Jan 16, 2020
@sbhadr
Copy link
Member

sbhadr commented Jan 16, 2020

I've been planning to update this system. So far, no other files need to be auto-updated. Other needed files are pulled directly from git. Which files do you think need to be auto-updated?

@Pythonic-Rainbow
Copy link
Member Author

The upcoming #28

@sbhadr
Copy link
Member

sbhadr commented Jan 16, 2020

What about that pull ?

@Pythonic-Rainbow
Copy link
Member Author

It will create stuff in jsons folder

@sbhadr
Copy link
Member

sbhadr commented Jan 16, 2020

Is it not pulling from the repo per every command invoke?

@Pythonic-Rainbow
Copy link
Member Author

I can make it do so but I think fetching it everytime can be a waste in resources.

@sbhadr
Copy link
Member

sbhadr commented Jan 16, 2020

This should make it easier to generate multiple files. b8c5f4b

@Pythonic-Rainbow
Copy link
Member Author

Perhaps another way is to cache the fetched files

@sbhadr
Copy link
Member

sbhadr commented Jan 20, 2020

Cached files are less efficient unless the source loads asynchronous while the bot is still active. For that to happen, we'd have to port to a cog-like system.

@Pythonic-Rainbow
Copy link
Member Author

I wonder if the cog system can be updated individually now?

@sbhadr
Copy link
Member

sbhadr commented Jun 30, 2020

It can. I just have to make it a command.

@Pythonic-Rainbow
Copy link
Member Author

oh shit it has been 1 year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussions. question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants